New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@kba
Contributor

kba commented Dec 6, 2018

One error was because https://github.com/bagit-profiles/bagit-profiles/blob/master/bagProfileBar.json changed.

The other error was because absolute paths were checked against relative wildcards. No idea how that slipped through.

@kba kba referenced this pull request Dec 6, 2018

Merged

Validate tag files allowed #14

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Dec 6, 2018

Ah, I see now. Tests run fine locally for me.

I have really limited experience with CircleCI, and confused why the tests aren't triggering consistently on pull requests. I've never seen this with TravisCI. Any idea what's going on here? Something configured wrong maybe?

@kba

This comment has been minimized.

Contributor

kba commented Dec 6, 2018

No idea, web hooks getting lost in some queue on either Github or CircleCI side I guess. It finished successfully though https://circleci.com/gh/kba/bagit-profiles-validator/tree/fixes

This does happen with Travis as well, though not as often. With Travis, it often happens that builds fail because network glitches on their part prevent a container booting.

Main reason why I prefer CircleCI is that it is much faster and uses newer containers (Travis is still running ubuntu 14.04).

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Dec 6, 2018

screenshot from 2018-12-06 08-59-42

The default for this is "off".

@kba

This comment has been minimized.

Contributor

kba commented Dec 6, 2018

The default for this is "off".

That's to prevent people stealing any environment secrets (eg AWS keys) by sending a PR with malicious code.

I can't wrap my head around it right now why not this was built at all if PR building was off. Or why in #17 only 2 of 5 tests sent success status.

If nothing else works, "Restart workflow" (Circle) or "Rebuild" (Travis) usually does.

@ruebot

This comment has been minimized.

Collaborator

ruebot commented Dec 6, 2018

Yeah, it's definitely behaving strangely. I don't see this or the other two PRs here. Am I missing something?

@ruebot

ruebot approved these changes Dec 7, 2018

@ruebot ruebot merged commit 1403fb5 into bagit-profiles:master Dec 7, 2018

5 checks passed

ci/circleci: build-python27 Your tests passed on CircleCI!
Details
ci/circleci: build-python34 Your tests passed on CircleCI!
Details
ci/circleci: build-python35 Your tests passed on CircleCI!
Details
ci/circleci: build-python36 Your tests passed on CircleCI!
Details
ci/circleci: build-python37 Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment