New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fresh UA spectra to NORMAN MassBank #41

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
3 participants
@nalygizakis
Contributor

nalygizakis commented Dec 20, 2018

Hi,

I uploaded 178 new records. Chromatograms were processed with the newest version of RMassBank. Please, merge and upload to our repository.

Kind Regards,
Nikiforos

nalygizakis added some commits Dec 20, 2018

@meier-rene

This comment has been minimized.

Collaborator

meier-rene commented Dec 20, 2018

Thank you for your new submission to MassBank. I would like to solve a few issues with you. We have a number of too long ACCESSION/file names. Please go through the list below and propose new names:
AU2274510.txt
AU2274511.txt
AU2274512.txt
AU2276510.txt
AU2276512.txt
AU2280510.txt
AU2280511.txt
AU2280512.txt
AU2281510.txt
AU2281511.txt
AU2281512.txt
AU2286510.txt
AU2286512.txt
AU2287512.txt

I dont know exactly, is this an issue of RMassBank? Should we create an issue there, so that it gets fixed for the future?

@schymane

This comment has been minimized.

Member

schymane commented Dec 20, 2018

@nalygizakis

This comment has been minimized.

Contributor

nalygizakis commented Dec 20, 2018

This is not a problem of RMassBank. However, it is a little bit of a problem that I have to edit manually the records after their generation, so that
-01 corresponds to 10eV positive
-02 corresponds to 20eV positive
...
-06 corresponds to Ramp positive
-07 corresponds to 10eV negative
-08 corresponds to 20eV positive etc
...

This is why this mistake happened. Unfortunately, file name and accession should change as follows:
AU2274510.txt-->AU227410.txt
AU2274511.txt-->AU227411.txt
AU2274512.txt-->AU227412.txt
AU2276510.txt-->AU227610.txt
AU2276512.txt-->AU227612.txt
AU2280510.txt-->AU228010.txt
AU2280511.txt-->AU228011.txt
AU2280512.txt-->AU228012.txt
AU2281510.txt-->AU228110.txt
AU2281511.txt-->AU228111.txt
AU2281512.txt-->AU228112.txt
AU2286510.txt-->AU228610.txt
AU2286512.txt-->AU228612.txt
AU2287512.txt-->AU228712.txt

@meier-rene meier-rene merged commit 2bd400e into MassBank:master Jan 3, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@meier-rene

This comment has been minimized.

Collaborator

meier-rene commented Jan 3, 2019

Thank you for contributing, all new spectra are merged into main repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment