/margins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed small typos in introduction vignette #108

Merged
merged 2 commits into from Jan 22, 2019

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@philip-khor @leeper
@philip-khor
Copy link
Contributor

philip-khor commented Jan 21, 2019 •
edited

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

philip-khor added some commits Jan 21, 2019

@philip-khor
Correct small typos in introduction vignette
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5e1589a
@philip-khor
Add changes made by devtools::check() and devtools::build_vignettes()
Loading status checks…
8362546

@leeper leeper merged commit de56121 into leeper:master Jan 22, 2019
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@leeper

This comment has been minimized.

Sign in to view
Copy link
Owner

leeper commented Jan 22, 2019

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment