/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections Helper: display_domains coverage #158

Closed
ruebot opened this Issue Aug 20, 2018 · 0 comments

Comments

Assignees

@ruebot ruebot

Labels
tests
Projects
None yet
Milestone
No milestone
1 participant
@ruebot
@ruebot
Copy link
Member

ruebot commented Aug 20, 2018

Missing coverage here.

I think we need mock a path here, and probably provide a test fixture to do this right.

@ruebot ruebot added the tests label Aug 20, 2018

@ruebot ruebot self-assigned this Aug 20, 2018

ruebot added a commit to ruebot/auk that referenced this issue Jan 24, 2019

@ruebot
Add test coverage for display_domains and filtered text path helpers. 
- Resolves archivesunleashed#158
- Add fixture to test display_domains helper
- Update existing tests for updated fixture setup
- Update fixture yamls to reflect updated fixture assets
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
3d0f469

@ruebot ruebot referenced this issue Jan 24, 2019

Merged

Add test coverage for display_domains and filtered text path helpers. #254

@ianmilligan1 ianmilligan1 closed this in #254 Jan 24, 2019

ianmilligan1 added a commit that referenced this issue Jan 24, 2019

@ruebot @ianmilligan1
Add test coverage for display_domains and filtered text path helpers. (… 
…#254)

- Resolves #158
- Add fixture to test display_domains helper
- Update existing tests for updated fixture setup
- Update fixture yamls to reflect updated fixture assets
Loading status checks…
eb39de9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment