Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up🚨 [security] Upgrade rubocop: 0.48.1 → 0.61.1 (major) #216
+10
−8
Conversation
depfu
bot
added
the
depfu
label
Dec 11, 2018
depfu
bot
force-pushed the
depfu/update/rubocop-0.61.1
branch
from
6d1406b
to
37bcd50
Dec 11, 2018
depfu
bot
changed the title from
🚨 [security] Upgrade rubocop: 0.48.1 → 0.61.1 (major)
to
🚨 [security] Upgrade rubocop: 0.48.1 → 0.61.1 (major)
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
===========================================
- Coverage 92.49% 34.54% -57.96%
===========================================
Files 35 22 -13
Lines 533 414 -119
===========================================
- Hits 493 143 -350
- Misses 40 271 +231
Continue to review full report at Codecov.
|
depfu
bot
force-pushed the
depfu/update/rubocop-0.61.1
branch
from
37bcd50
to
38594c1
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
|
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/rubocop-0.61.1
branch
from
38594c1
to
483fd51
Dec 11, 2018
ruebot
closed this
in
6cbaf87
Dec 11, 2018
depfu
bot
deleted the
depfu/update/rubocop-0.61.1
branch
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedDec 11, 2018
•
edited
Advisory: CVE-2017-8418
Disclosed: May 01, 2017
URL: https://github.com/bbatsov/rubocop/issues/4336
RuboCop: insecure use of /tmp
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.61.0
New features
Style/RegexpLiteral. (@r7kamura)Style/Lambda. (@r7kamura)Style/MethodCallWithArgsParenthesescop. (@gsamokovarov)Performance/OpenStructchecks forOpenStruct.newcalls. (@xlts)Bug fixes
Layout/RescueEnsureAlignmenterror on assigned blocks. (@gmcgibbon)Lint/UselessAssignmentwhen using a variable in a module name. (@itsWill)--auto-gen-configand--config FILEcorrectly. (@jonas054)--auto-gen-configin a subdirectory work. (@jonas054)unknown keywordserror when usingPsych.safe_loadwith Ruby 2.6.0-preview2. (@koic)Style/BracesAroundHashParameterswhen the opening brace is before the first hash element at same line. (@koic)yieldandsuperlike regular method calls inStyle/AlignHash. (@mvz)Style/InfiniteLoop. (@jonas054)Style/TrailingCommaInArguments. (@jonas054)codingvariable. (@akihiro17)inherit_modeparameter to individual cop configurations. (@maxh)Layout/IndentationWidthwhen settingEnforcedStyle: railsofLayout/IndentationConsistencyand method definition indented to access modifier in a singleton class. (@koic)Lint/FormatParameterMismatchwhen using (digit)$ flag. (@koic)Style/UnneededConditionwhenifcondition andthenbranch are the same and it has noelsebranch. (@koic)Style/FrozenStringLiteralwhen a file contains only a shebang. (@takaram)Style/EmptyCaseConditionwhen used as an argument of a method. (@koic)Style/RaiseArgswhen an exception object is assigned to a local variable. (@koic)Lint/UselessAccessModifierwhen usingprivate_class_method. (@dduugg)Performance/RedundantMergeraises an error on a sole double splat argument passed tomerge!. (@mmedal)ifnodes even if the first branch is empty. (@bquorning)Changes
Layout/CommentIndentationto avoid unnecessary iterations forrubocop -a. (@jonas054)0.60.0
New features
--safeand--safe-auto-correctoptions. (@Darhazer)--auto-gen-only-exclude. (@Ana06, @jonas054)VersionAddedmeta data to config/default.yml when runningrake new_cop. (@koic)Whitelistconfig toRails/SkipsModelValidationsrule. (@DiscoStarslayer)Bug fixes
Rails/ReversibleMigrationwhen using variable assignment. (@koic, @scottmatthewman)Style/RedundantFreezeand a false negative forStyle/MutableConstantwhen assigning a regexp object to a constant. (@koic)Style/RedundantFreezewhen assigning a range object to a constant. (@koic)Rails/ReversibleMigrationwhen block argument is empty. (@koic)LineLengthcop for tab-indented code. (@AlexWayfer)Changes
keyoption inLayout/AlignHashcop. (@albaer)0.59.2
Bug fixes
Rails/HasManyOrHasOneDependentwhen using associations of Active Resource. (@tejasbubane, @koic)Style/Forwhen settingEnforcedStyle: eachandfordose not havedoor semicolon. (@autopp)Layout/EmptyLineAfterGuardClausewhen guard clause including heredoc. (@koic)AllowURIoption forMetrics/LineLengthcop with disabledLayut/Tabcop. (@AlexWayfer)Metrics/BlockLengthinto the respective length cops. (@drenmi)Style/ZeroLengthPredicatefalse positives when inspectingTempfile,StringIO, andFile::Statobjects. (@drenmi)Layout/EmptyLinesAroundAccessModifierandLayout/EmptyLinesAroundAccessModifierwhen specifying a superclass that breaks the line. (@koic)Style/IfUnlessModifierwhen using named capture. (@drenmi)Style/Semicolonfrom breaking on single line if-then-else in assignment. (@drenmi)Rails/HasManyOrHasOneDependentwhen an Active Record model does not have any relations. (@koic)Style/Forwhen settingEnforcedStyle: eachwith range provided to theforloop without adokeyword or semicolon and without enclosing parenthesis. (@lukasz-wojcik)Changes
Metrics/MethodLength. (@akanoi)0.59.1
Bug fixes
Rails/FindEach. (@Knack)Naming/FileNamewhen investigating gemspecs. (@kddeisz)Naming/FileNamewhen investigating dotfiles. (@sinsoku)Style/EmptyCaseConditionauto-correction removes comment betweencaseand firstwhen. (@koic)Style/RedundantBeginwhen callingsuperwith a block. (@eitoball)Layout/EmptyLineAfterGuardClausewhen guard clause is after heredoc including string interpolation. (@koic)Style/MultilineMethodSignature. (@drenmi)Layout/EmptyLineAfterGuardClausecop whenifcondition is after heredoc. (@koic)Changes
Lint/UnreachableCodedetectexit,exit!andabort. (@hoshinotsuyoshi)#===fromNaming/BinaryOperatorParameterName. (@zverok)+to allowed file names ofNaming/FileName. (@yensaki)0.59.0
New features
Bundler/GemCommentcop. (@sunny)IgnoredMethodsoption toStyle/NumericPredicatecop. (@AlexWayfer)--display-only-fail-level-offensesto only output offenses at or above the fail level. (@robotdana)Style/For. (@rrosenblum)AllowImplicitReturnoption toRails/SaveBangcop. (@robotdana)comparisonstyle toStyle/NilComparison. (@khiav223577)Style/MultilineMethodSignaturecop. (@drenmi)Performance/ChainArrayAllocationcop. (@schneems)Layout/EmptyLinesAroundClassBodyaware of specifying a superclass that breaks the line. (@koic)Bug fixes
Style/DateTimenot detecting#to_datetime. It can be configured to allow this. (@bdewater)Naming/FileNamewhenIncludeofAllCopsis the default setting. (@koic)Layout/MultilineOperationIndentation. (@jonas054)Layout/ClosingParenthesisIndentationwhen method arguments are empty with newlines. (@tatsuyafw)Layout/AccessModifierIndentationwhen using access modifiers with arguments within nested classes. (@gmalette)Style/IfUnlessModifiercop for disabledLayout/Tabcop when there is noIndentationWidthconfig. (@AlexWayfer)AllowURIoption ofMetrics/LineLengthcop for files with tabs indentation. (@AlexWayfer)Style/UnneededConditionwhen using operator method higher precedence than||. (@koic)Lint/ShadowedArgument. (@jonas054)Layout/MultilineHashBraceLayoutandLayout/MultilineArrayBraceLayoutauto-correct syntax error when there is a comment on the last element. (@bacchir)Style/BracesAroundHashParametersauto-correct syntax error when there is a trailing comma. (@bacchir)Style/RedundantBeginaware of stabby lambdas. (@drenmi)Naming/PredicateName. (@sunny)Style/EmptyCaseConditionwhen usingreturninwhenclause and assigning the return value ofcase. (@koic)Rails/Delegate. (@sunny)Style/WordArraywhen settingEnforcedStyle: bracketsand using string interpolation in%Wliteral. (@koic)Lint/RescueEnsureAlignmentwhenendis misaligned. The alignment and message are now based on the beginning position rather than theendposition. (@rrosenblum)Dateusage inStyle/DateTime. (@deivid-rodriguez)Changes
Rails/FindEachcop. Makes the cop also check for the following scopes:eager_load,includes,joins,left_joins,left_outer_joins,preload,references, andunscoped. (@repinel)dbto allowed names ofNaming/UncommunicativeMethodParamNamecop in default config. (@mkenyon)Lint/DuplicateMethodsto include the method name. (@rrosenblum)rubocop --auto-gen-confif the todo file is successfully created even if there are offenses. (@MagedMilad)Rails/RelativeDateConstantby default. (@koic)*) to match the hidden file. (@koic)Style/Fornow highlights the entire statement rather than just the keyword. (@rrosenblum)Performance/CaseWhenSplatand its auto-correction by default. (@rrosenblum)Layout/EmptyLineAfterGuardClausecop by default. (@koic)Style/DateTimehas been moved to disabled by default. (@deivid-rodriguez)0.58.2
Changes
New features
#6105: Support
{a,b}file name globs inExcludeandIncludeconfig. (@mikeyhew)#6116: Add
ipto allowed names ofNaming/UncommunicativeMethodParamNamecop in default config. (@nijikon)Bug fixes
Layout/IndentationWidthwhen multiple modifiers are used in a block and a method call is made at end of the block. (@koic)Naming/MemoizedInstanceVariableNamecop to allow methods to have leading underscores. (@kenman345)Layout/ClassStructurewhen there is a comment in the macro method to be auto-correct. (@koic)Lint/OrderedMagicCommentswhen using{ encoding: Encoding::SJIS }hash object afterfrozen_string_literalmagic comment. (@koic)0.58.1
Bug fixes
Style/MethodCallWithArgsParentheseswhen arguments are method calls. (@maxh)Style/RedundantParentheseswith hash literal as first argument tosuper. (@maxh)Gemspec/OrderedDependencieswhen using method call to gem names in gemspec. (@koic)Rails/BulkChangeTableaware of variable table name. (@wata727)Layout/MultilineAssignmentLayoutcop when using multi-line block defines on separate lines. (@koic)0.57.2
Bug fixes
Layout/ClosingHeredocIndentationfrom raising an error on<<heredocs. (@dvandersluis)Layout/ClosingHeredocIndentationfrom raising an error on heredocs containing only a newline. (@drenmi)Layout/IndentationConsistencycop triggered by an empty expression string interpolation. (@alexander-lazarov)Style/MethodCallWithArgsParenthesesfrom raising an error in certain cases. (@drenmi)0.57.1
Bug fixes
inherit_modedirective. (@jonas054)Layout/IndentationWidthwhen an access modifier section has an invalid indentation body. (@tatsuyafw)Layout/IndentationConsistencyshould still register an offense for private methods. (@jaredbeck)Rails/BulkChangeTable. (@wata727)Style/UnneededConditioncop accepts a case of condition andif_branchare same when usingelsifbranch. (@koic)0.57.0
New features
Rails/BulkChangeTablecop. (@wata727)Style/AccessModifierDeclarationscop. (@brandonweiss)Style/UnneededConditioncop. (@balbesina)Layout/ClosingHeredocIndentationcop. (@siggymcfried)slashesstyle toRails/FilePathsince Ruby accepts forward slashes even on Windows. (@sunny)Layout/LeadingBlankLineschecks for empty lines at the beginning of a file. (@rrosenblum)Bug fixes
Style/SymbolArrayandStyle/WordArraynot working on arrays of size 1. (@TikiTDO)Rails/AssertNotto allow it to have failure message. (@koic)headersorenvkeyword arguments inRails/HttpPositionalArguments. (@rrosenblum)Style/BracesAroundHashParametersauto-correct going past the end of the file when the closing curly brace is on the last line of a file. (@EiNSTeiN-)Style/FrozenStringLiteralCommentwould be added to the second line if the first line is empty. (@rrosenblum)Layout/SpaceInsideReferenceBracketsaware ofno_spacewhen using nested reference brackets. (@koic)Style/MixinGroupingwhen method namedincludeaccepts block. (@Darhazer)Changes
--fix-layout/-xcommand line alias. (@scottmatthewman)Lint/SplatKeywordArgumentscop. (@koic)httpdateto acceptedRails/TimeZonemethods. (@cupakromer)xmlschemato acceptedRails/TimeZonemethods. (@koic)rake repltask tobin/consolecommand. (@koic)inherit_modework for default configuration too. (@jonas054)unicode/display_width. (@nroman-stripe)Not all release notes shown. View the full release notes
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by 51 commits:
Let's don't talk about String mixin anymoreMerge branch 'release-3-0'Merge pull request #79 from sickill/fix/rubocop-051RuboCop 0.51.0Spec: RSpec.describe, not describeMerge pull request #77 from sickill/refinementsRSpec: disable monkey patching (#78)README: add video example [ci skip]Amend READMEDrop RUBY_VERSION checkRefinements supported in Ruby 2.1Add String refinement when using Ruby >= 2.0Travis: RVM note, extract env, cache bundler right; Appveyor: fix build (#75)Remove spec for legacy namespaceRemove really old legacy supportAdd Olle Jonsson as author to gemspecUpdate changelogTravis: jruby-9.1.13.0Merge pull request #70 from sickill/fix/add-example-of-rand-colorREADME: Add the pick-random-color [ci skip]Merge pull request #54 from ypresto/add-strip-ascii-escapeMerge pull request #66 from swrobel/patch-1Reverse Changelog orderAdd uncolor methodMerge pull request #64 from sickill/fix/rubocop-0-49-1RuboCop config typoRuboCop: exclude vendor folderRuboCop: crlf ruleGemfile: RuboCop in :test AND :development groupRuboCop 0.49.1; rake task; lintingAdd appveyor badgeMerge pull request #59 from olleolleolle/fix/rubocop-updatesMerge pull request #63 from olleolleolle/patch-2Travis: jruby-9.1.12.0Merge pull request #62 from olleolleolle/patch-2Travis: upgrade rubiesMerge pull request #60 from olleolleolle/patch-1Merge pull request #61 from deivid-rodriguez/remove_debugging_statementRemove debugging statement from appveyor configTravis: use jruby-9.1.10.0 in CI matrixMerge pull request #55 from deivid-rodriguez/add_appveyorTemporarily build selfStart testing the gem under WindowsRubocop: Configrubocop -aRubocop: note target version, exclude specAdd gem version to READMEBump versionRemove rake dependencyMerge pull request #46 from deivid-rodriguez/drop_193_supportMerge branch 'master' into drop_193_supportDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands