/auk

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for disk_usage; resolves #159. #252

Merged
merged 1 commit into from Jan 24, 2019
+16 −10

Conversation

Reviewers

@ianmilligan1 ianmilligan1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @codecov-io @ianmilligan1
@ruebot
Copy link
Member

ruebot commented Jan 24, 2019

  • Update DOWNLOAD_PATH variable
  • Update rubocop config
  • Add test fixture directory for DOWNLOAD_PATH

Let's see how this runs with TravisCI.
@ruebot
Add test for disk_usage; resolves #159. 
- Update DOWNLOAD_PATH variable
- Update rubocop config
- Add test fixture directory for DOWNLOAD_PATH
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
43ec677
@codecov-io

This comment has been minimized.

Sign in to view
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #252 into master will increase coverage by 0.96%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   92.39%   93.35%   +0.96%     
==========================================
  Files          35       35              
  Lines         539      542       +3     
==========================================
+ Hits          498      506       +8     
+ Misses         41       36       -5
Impacted Files Coverage Δ
test/helpers/wasapi_files_helper_test.rb 100% <100%> (ø) ⬆️
test/helpers/collections_helper_test.rb 100% <100%> (ø) ⬆️
test/helpers/dashboards_helper_test.rb 100% <100%> (ø) ⬆️
app/helpers/wasapi_files_helper.rb 62.5% <0%> (+20.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b31d036...5aba756. Read the comment docs.

@ruebot ruebot force-pushed the ruebot:test-settings branch from 5aba756 to 43ec677 Jan 24, 2019

@ruebot

This comment has been minimized.

Sign in to view
Copy link
Member

ruebot commented Jan 24, 2019

@ianmilligan1 can you squash and merge this?
@ianmilligan1

ianmilligan1 approved these changes Jan 24, 2019
View changes

@ianmilligan1 ianmilligan1 merged commit e2ba4a1 into archivesunleashed:master Jan 24, 2019
3 checks passed

3 checks passed

codecov/patch 100% of diff hit (target 92.39%)
Details
codecov/project 93.35% (+0.96%) compared to b31d036
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruebot ruebot deleted the ruebot:test-settings branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment