/jekyll

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Widths on Lessons w/o Reviewers Too Small #1140

Closed
walshbr opened this Issue Dec 21, 2018 · 0 comments

Comments

Assignees

@walshbr walshbr

Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@walshbr
@walshbr
Copy link
Contributor

walshbr commented Dec 21, 2018

We have four lessons that have no reviewers and no reviewer ticket. The design doesn't currently account for this scenario, and when we don't have a "peer-reviewed" link present it squeezes the CC note.

Screenshot of how it's expected to look:

screen shot 2018-12-21 at 10 33 12 am

Screenshot of one of the affected lessons:

screen shot 2018-12-21 at 10 32 01 am

@walshbr walshbr added the bug label Dec 21, 2018

@walshbr walshbr self-assigned this Dec 21, 2018

walshbr added a commit that referenced this issue Dec 21, 2018

@walshbr
Closes #1140
Loading status checks…
e808b90

@walshbr walshbr referenced this issue Dec 21, 2018

Merged

Account for lessons that have no reviewers in design #1141

@walshbr walshbr closed this in #1141 Dec 22, 2018

walshbr added a commit that referenced this issue Dec 22, 2018

@walshbr
Closes #1140 (#1141)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5bed1ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment