Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upStandardize gallery image sizes #1139
Conversation
walshbr
added
bug
enhancement
labels
Dec 21, 2018
walshbr
self-assigned this
Dec 21, 2018
walshbr
requested a review
from
mdlincoln
Dec 21, 2018
mdlincoln
reviewed
Jan 8, 2019
|
Thanks for fixing this, and sorry I'm only just looking at it now @walshbr! On top of fixing up the images, I wonder if there's some tweak we can make to the CSS or to the image classes so that the avatars are always consistently-sized? Perhaps creating a class |
This comment has been minimized.
This comment has been minimized.
|
@mdlincoln - I'll take a look! Where are they inconsistently sized? On the project team page? And do you mean consistently sized as the window scales down? Or relative to itself just within one window size? |
This comment has been minimized.
This comment has been minimized.
|
No, all the images you uploaded are ok. What I meant was configuring the CSS so that if anyone happens to upload, say, a 250px wide image in the future, then the display on the lesson page, as well as the lessons list page, works out ok. |
This comment has been minimized.
This comment has been minimized.
|
Gotcha. How about this then? Added max-width to a lesson-avatar class on the lesson images only on the individual lesson pages. |
mdlincoln
added some commits
Jan 10, 2019
This comment has been minimized.
This comment has been minimized.
|
silly me, the width of that image is actually controlled by a wrapper |
walshbr commentedDec 21, 2018
Closes #1138.
I think I checked everything to make sure this didn't cause any weirdness or grab any images that we didn't want resized (banner/splash images).