Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upLanguage links refactor #818
Conversation
mdlincoln
added some commits
Apr 7, 2018
mdlincoln
added
technical
translation
labels
Apr 27, 2018
mdlincoln
self-assigned this
Apr 27, 2018
mdlincoln
requested review from
walshbr
and
arojascastro
Apr 27, 2018
walshbr
approved these changes
Apr 27, 2018
arojascastro
approved these changes
Apr 29, 2018
Ok, thank you for this. I understand that you changed already the metadata of the existing translations by replacing |
mdlincoln
added some commits
May 5, 2018
mdlincoln
merged commit 5329dca
into
gh-pages
May 5, 2018
mdlincoln
deleted the
language-refactor
branch
May 5, 2018
mdlincoln
added this to the French Integration milestone
May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mdlincoln commentedApr 27, 2018
•
edited
This is a major back-end modification that adjusts how to point to and from translations and their sources. As a result, we should now theoretically be able to host any number of languages on the site. Another nice benefit is that clicking on the
[es]
or[en]
links at the top of the page should now - when there is a translation / translation source - take you to the companion page for the one you were just on, rather than dumping you all the way back at the home page for that language.This works by doing two searches every time a page is generated:
This results in only one change for the editorial guidelines for producing translations: instead of using
redirect-from: /lessons/LESSON-SLUG
, editors will now useoriginal: LESSON-SLUG
(note no leading directory information). I've already gone through and updated all the existing translations for this. All new translations of non-lesson pages will also require thisoriginal
tag. Doing this means we have a dedicated bit of metadata for finding translation sources, and leavesredirect-from
to do its important work of ensuring good redirects without saddling it with other responsibilities.I still have a few open tasks:
original
tags appropriately (might be a separate PR since #816 is also underway right now)Closes: #785
Re: #651