New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve df/package.scala test coverage #264

Closed
ruebot opened this Issue Aug 14, 2018 · 3 comments

Comments

2 participants
@ruebot
Copy link
Member

ruebot commented Aug 14, 2018

df/package.scala test coverage can be improved.

@ruebot ruebot added this to To Do in Test coverage Aug 14, 2018

@jrwiebe

This comment has been minimized.

Copy link
Contributor

jrwiebe commented Jan 31, 2019

Have a quick look at the coverage report, @ruebot. Is it important to test for the event that those partial coverage if-statements evaluate to false? Just trying to get a sense of our testing standards.

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Jan 31, 2019

It'd probably be good to test those, but I wouldn't say it's a high priority.

@jrwiebe

This comment has been minimized.

Copy link
Contributor

jrwiebe commented Feb 1, 2019

I can't think of a way to get to:

            if (image != null) {

Since getImageReaders returns all registered ImageReaders that claim to be able to decode the supplied input, we only get a reader when the encoded image bytes string is valid. But if the bytes string is an image and we enter the if (readers.hasNext()) {} block, the image = reader.read(0) should never be null.

I think test coverage is virtually complete with my latest commit.

@ruebot ruebot added the wontfix label Feb 1, 2019

@ruebot ruebot closed this Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment