Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: Python Sorted Containers #1223
Comments
whedon
added
the
pre-review
label
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1223 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in |
whedon
added
Python
Shell
labels
Jan 31, 2019
This comment has been minimized.
This comment has been minimized.
This software looks useful, even though there's a problem compiling the paper. You can make changes to the source, then enter Another issue I have is that it's not clear to me that this is research software according to the JOSS guidelines:
Can you help me understand this? |
This comment has been minimized.
This comment has been minimized.
grantjenks
commented
Feb 2, 2019
Regarding the guidelines, I think it fits under:
But I may be wrong. I had JOSS suggested to me by the creator of IPython. And I received a GitHub Issue asking how to cite the project. Consider some of the users:
Does that satisfy? Also, I looked through GitHub issues trying to understand how the PDF is generated:
But I was unable to reproduce the problem. (Maybe those links will be useful for a future visitor). There seems to be a "paper.md" file that is missing. Is that something I generate? I'm happy to accommodate, just not sure what's necessary. I could see how the project README may not be as useful for a paper as say the Performance Comparison, Implementation Details, or Performance at Scale materials. |
This comment has been minimized.
This comment has been minimized.
Hi @grantjenks - please take a look at the submission guidelines and prepare a In your paper, please be sure to address each of the points listed in the section what should my paper contain?. |
This comment has been minimized.
This comment has been minimized.
Regarding the research application, the problem is that your package is not used by end users for research, but according to your comment, is used by other libraries and packages, some of which then are used for research. I think that's fine, but want to hear from @arfon before we go on. |
whedon commentedJan 31, 2019
Submitting author: @grantjenks (Grant Jenks)
Repository: https://github.com/grantjenks/python-sortedcontainers
Version: v2.1.0
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @grantjenks. The JOSS editor Pending, will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@grantjenks if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: