Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[PRE REVIEW]: dfitspy #1217
Comments
whedon
added
the
pre-review
label
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1217 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon.rb:83:in |
whedon
added
HTML
Makefile
Python
labels
Jan 29, 2019
This comment has been minimized.
This comment has been minimized.
@astrom-tom - I don't see any .bib file in your repo, and your reference is written manually, rather than being compiled. Please refer to https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography for an example. Once you've made changes in your repository, enter |
This comment has been minimized.
This comment has been minimized.
You also need some real content in the readme, including the purpose of the software, what problems it can solve, a pointer to how it can be installed and tested, how others can contribute, etc. See https://joss.readthedocs.io/en/latest/review_criteria.html, which states:
|
This comment has been minimized.
This comment has been minimized.
Also, I see a bunch of temporary files inside the repository that you might want to remove - those that end with |
This comment has been minimized.
This comment has been minimized.
Once these changes are made, let me know and we'll move forward to assigning an editor |
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Jan 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
PDF failed to compile for issue #1217 with the following error: /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-c5f29247288e/lib/whedon.rb:83:in |
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Jan 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Jan 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Jan 31, 2019
•
Dear @danielskatz, Thank you for dealing with my submission. For the readme, there is only one link that goes to github pages (full documentation made with sphinx). Is that enough? Thanks again! |
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Jan 31, 2019
@whedon generate pdf |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
No, it's not. This is what I wrote in #1217 (comment) |
This comment has been minimized.
This comment has been minimized.
astrom-tom
commented
Feb 2, 2019
A high-level overview of this documentation should be included in a README file (or equivalent). What means 'or equivalent'? |
This comment has been minimized.
This comment has been minimized.
Equivalent is in case the software is not on github and in some other system where the initial file has some other name. |
This comment has been minimized.
This comment has been minimized.
|
whedon commentedJan 29, 2019
Submitting author: @astrom-tom (Romain Thomas)
Repository: https://github.com/astrom-tom/dfitspy
Version: v19.1.5
Editor: Pending
Reviewer: Pending
Author instructions
Thanks for submitting your paper to JOSS @astrom-tom. The JOSS editor Pending, will work with you on this issue to find a reviewer for your submission before creating the main review issue.
@astrom-tom if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type: