Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse AUTO_LANGUAGE everywhere #592
Conversation
egonw
requested a review
from
fnielsen
Dec 23, 2018
fnielsen
reviewed
Jan 7, 2019
I wonder if it is a good way to remove all languages? What if your AUTO_LANGUAGE and English is not set? For instance, I probably browse with Danish locale and if I see a work that is only set in French I would not see any label? |
This comment has been minimized.
This comment has been minimized.
I was mostly concerned with the redundancy... can we make this a global value and then insert it into all the SPARQL queries, so that we have one place to add/update it? So the SPARQL query would have something like topicsSparql = `
#defaultView:Table
SELECT ?count ?theme ?themeLabel ?example_work ?example_workLabel
WITH {
SELECT (COUNT(?work) AS ?count) ?theme (SAMPLE(?work) AS ?example_work)
WHERE {
?work wdt:P50 wd:{{ q }} .
?work wdt:P921 ?theme .
}
GROUP BY ?theme
} AS %result
WHERE {
INCLUDE %result
{{ serviceLabel }}
}
ORDER BY DESC(?count) And that new variable is globally defined somewhere, either What do you think? |
This comment has been minimized.
This comment has been minimized.
Instead of constructs like
|
egonw commentedDec 23, 2018
No description provided.