Fixes T #1351

zuphilip · Jul 5, 2017

Finally, this is the last letter in my tour from A to Z 🎉 .

Please have a look at these fixes, update and rewrites.

adam3smith · Jul 6, 2017

@zuphilip -- any views on the test here? It shouldn't fail, but can't handle the rename of the translator. Since that test only goes for individual PRs (i.e. won't keep failing), we could just ignore it, or do you want to try to fix the test?

zuphilip · Jul 6, 2017

Here it is a rename and completely rewrite which will not work for Travis. I tried some improvements in the linked PR, but also with this improved script, Travis will still complain. Thus, I suggest to ignore Travis on this here.

adam3smith · Jul 9, 2017

adam3smith requested changes Jul 9, 2017

View changes

whew. That was a marathon. Given that, quite few comments and all should be pretty quick.

adam3smith · Jul 9, 2017

The Free Dictionary.js

 				"notes": [
 					{
-						"note": "n.1. a. Physical or mental exertion, especially when difficult or exhausting; work. See Synonyms at work.b. Something produced by work.2. A specific task.3. A particular form of work or method of working: manual labor.4. Work for wages.5. a. Workers considered as a group.b. The trade union movement, especially its officials.6. Labor A political party representing workers' interests, especially in Great Britain.7. The process by which childbirth occurs, beginning with contractions of the uterus and ending with the expulsion of the fetus or infant and the placenta."
+						"note": "n.1. Physical or mental exertion, especially when difficult or exhausting; work. See Synonyms at work.2. A specific task or effort, especially a painful or arduous one: \"Eating the bread was a labor I put myself through to quiet my stomach\" (Gail Anderson-Dargatz).3. A particular form of work or method of working: manual labor.4. Work for wages: businesses paying more for labor.5. a. Workers considered as a group.b. The trade union movement, especially its officials.6. Labor A political party representing workers' interests, especially in Great Britain.7. The process by which childbirth occurs, beginning with contractions of the uterus and ending with the expulsion of the fetus or infant and the placenta."


Not wild about all these notes -- let's put this into a single one?

adam3smith · Jul 9, 2017

The Guardian.js

+				item.creators.push(ZU.cleanAuthor(authors[i], "author"));
+			}
+		}
+		//FW.Xpath('//p[@class="byline"]').text().remove(/\s(in|for)\s.+/).split(/\s+and\s+|\s*,\s*/).cleanAuthor("author")


adam3smith · Jul 9, 2017

The Hamilton Spectator.js

+	//translator.setDocument(doc);
+
+	translator.setHandler('itemDone', function (obj, item) {
+		item.publicationTitle = "The Hamilton Spectator";


item.ISSN = "1189-9417";

adam3smith · Jul 9, 2017

The Hindu (old).js

@@ -2,14 +2,14 @@
 	"translatorID": "9499c586-d672-42d6-9ec4-ee9594dcc571",
 	"label": "The Hindu (old)",
 	"creator": "Prashant Iyengar and Michael Berkowitz",
-	"target": "^https?://(www\\.)?hindu\\.com/",
+	"target": "^https?://(www\\.)?thehindu\\.com/lr/",


let's also add item.ISSN = "0971-751X"; and remove Zotero.wait() and Zotero.done()

adam3smith · Jul 9, 2017

The Microfinance Gateway.js

+	if (authorString) {
+		var authors = authorString.split(/\.,|&/);
+		for (var i=0; i<authors.length; i++) {
+			item.creators.push(ZU.cleanAuthor(authors[i], "author"));


I think you need a , true here. note the authors in the tests have lastName & firstName swapped

adam3smith · Jul 9, 2017

The Times and Sunday Times.js

+					}
+				],
+				"date": "2017-07-02",
+				"ISSN": "0140-0460",


I think the Sunday times should be 0956-1382 see https://en.wikipedia.org/wiki/The_Sunday_Times

adam3smith · Jul 9, 2017

Toronto Star.js

+	***** END LICENSE BLOCK *****
+*/
+
+
 function detectWeb(doc, url) {
 	if (url.indexOf("search") != -1 && url.indexOf("classifieds") == -1) {


&& getSearchResults(doc, true)

adam3smith · Jul 9, 2017

Twitter.js

+	}
+	var urlParts = url.split('/');
+	item.blogTitle = '@' + urlParts[3];
+	item.websiteType = "microblog";


We should maybe reconsider this -- no one seems to actually use it. We could just say "Tweet" which is what APA uses (http://blog.apastyle.org/apastyle/2013/10/how-to-cite-social-media-in-apa-style.html ) and what MLA used to use ( https://www.theatlantic.com/technology/archive/2012/03/how-do-you-cite-a-tweet-in-an-academic-paper/253932/ )

adam3smith · Jul 9, 2017

taz.de.js

+				item.creators.splice(i, 1);
+			}
+		}
+


item.ISSN = "0931-9085";

adam3smith · Jul 9, 2017

taz.de.js

+	//translator.setDocument(doc);
+
+	translator.setHandler('itemDone', function (obj, item) {
+		item.publicationTitle = "taz. die tageszeitung";


I think this should just be "die tageszeitung", no?

In the ZDB we have Die Tageszeitung : taz which looks nice for me. I will change it to this.

zuphilip · Jul 10, 2017

Thank you for the helpful comments. Please have a look at the new version.

adam3smith · Jul 10, 2017

adam3smith reviewed Jul 10, 2017

View changes

adam3smith · Jul 10, 2017

taz.de.js

@@ -87,7 +87,8 @@ function scrape(doc, url) {
 	//translator.setDocument(doc);

 	translator.setHandler('itemDone', function (obj, item) {
-		item.publicationTitle = "taz. die tageszeitung";
+		item.publicationTitle = "Die Tageszeitung : taz";


without the space before the colon, though, no?

zuphilip · Jul 10, 2017

Yes, deleted space before colon.

adam3smith · Jul 15, 2017

Woot! You just finished the translator ironman!

zuphilip added some commits Jul 5, 2017

Update Twitter.js
Note that multiples work when site is loaded but not as autoamtic test cases.

80fb731

Fix date in The Hindu.js

Loading status checks…

6b9e711

zuphilip referenced this pull request Jul 6, 2017
Merged
Rename Bibliotheque et Archives Nationales du Quebec.js #1357

Update fixes-T according to review process

Loading status checks…

9fa11bf

Update taz.de.js

Loading status checks…

6bf6b85

adam3smith merged commit 1797efb into zotero:master Jul 15, 2017
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

zuphilip deleted the zuphilip:fixes-T branch Jul 15, 2017

zotero/translators

Fixes T #1351

Fixes T #1351

zuphilip commented Jul 5, 2017

zuphilip added some commits Jun 27, 2017

zuphilip added some commits Jul 5, 2017

This comment has been minimized.

adam3smith commented Jul 6, 2017

zuphilip referenced this pull request Jul 6, 2017

Rename Bibliotheque et Archives Nationales du Quebec.js #1357

This comment has been minimized.

zuphilip commented Jul 6, 2017

adam3smith requested changes Jul 9, 2017

View changes

adam3smith left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zuphilip commented Jul 10, 2017

adam3smith reviewed Jul 10, 2017

View changes

This comment has been minimized.

This comment has been minimized.

zuphilip commented Jul 10, 2017

adam3smith merged commit `1797efb` into zotero:master Jul 15, 2017
1 check failed

1 check failed

This comment has been minimized.

adam3smith commented Jul 15, 2017

zuphilip deleted the zuphilip:fixes-T branch Jul 15, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zotero/translators

Join GitHub today

Fixes T #1351

Conversation

zuphilip commented Jul 5, 2017

zuphilip added some commits Jun 27, 2017

zuphilip added some commits Jul 5, 2017

This comment has been minimized.

adam3smith commented Jul 6, 2017

zuphilip referenced this pull request Jul 6, 2017

This comment has been minimized.

zuphilip commented Jul 6, 2017

adam3smith requested changes Jul 9, 2017 View changes

adam3smith left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zuphilip commented Jul 10, 2017

adam3smith reviewed Jul 10, 2017 View changes

This comment has been minimized.

This comment has been minimized.

zuphilip commented Jul 10, 2017

Hide details View details adam3smith merged commit 1797efb into zotero:master Jul 15, 2017 1 check failed

1 check failed

This comment has been minimized.

adam3smith commented Jul 15, 2017

zuphilip deleted the zuphilip:fixes-T branch Jul 15, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

adam3smith requested changes Jul 9, 2017

View changes

adam3smith reviewed Jul 10, 2017

View changes

adam3smith merged commit `1797efb` into zotero:master Jul 15, 2017
1 check failed