New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translator Landesbibliographie Baden-Wurttemberg.js #1774

Merged
merged 4 commits into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Nov 1, 2018

No description provided.

zuphilip and others added some commits Nov 1, 2018

@adam3smith
Copy link
Collaborator

adam3smith left a comment

A couple of questions&requests, looks good otherwise. Thanks!

"items": [
{
"itemType": "journalArticle",
"title": "Überfordert : Mozart: Don Giovanni : Mannheim, Nationaltheater",

This comment has been minimized.

@adam3smith

adam3smith Nov 1, 2018

Collaborator

Could you remove spaces before colons in titles and update tests?

"fieldMode": 1
}
],
"date": "2000///(2001); 2001/02(2003) -",

This comment has been minimized.

@adam3smith

adam3smith Nov 1, 2018

Collaborator

Can we clean this? I'm not even sure how Zotero would end up parsing this date (though I think just as 2000?).

This comment has been minimized.

@zuphilip

zuphilip Nov 1, 2018

Collaborator

No, it is more complicated because here the whole series is meant. So

Erscheinungsverlauf: | 1972/73 - 1999/2000(2001); 2001/02(2003) -

means that there was a report for 1972/1973, ..., and another report for 1999/2000 published in 2001, but no report in 2000/2001 (the note explained why). Then from 2001/2002 in 2003 it started again normally.

How about moving the date in this case to a note? Deleting would be okay also for me, because these report (series) are not my main focus here.

This comment has been minimized.

@adam3smith

adam3smith Nov 1, 2018

Collaborator

I'd still pick a date to import, maybe the first one? Putting the rest into notes sounds right.

"title": "Rechenschaftsbericht ... des Rektors",
"creators": [
{
"lastName": "Universität ",

This comment has been minimized.

@adam3smith

adam3smith Nov 1, 2018

Collaborator

This is as <Mannheim> in the RIS export and then apparently ignored by Zotero. I'm suspecting because that was your search term? I think it's save to just clean pointy brackets from the RIS completely?

This comment has been minimized.

@zuphilip

zuphilip Nov 1, 2018

Collaborator

This comes from

AU  - Universität <Mannheim>

which is catalogued as a "Körperschaft" in the original. Maybe we could move it to a contributor but I don't know how to identifies these cases. Thoughts?

This comment has been minimized.

@adam3smith

adam3smith Nov 1, 2018

Collaborator

Sorry, I had seen that but markdown swallowed the relevant bit. I think we should leave it as author, which seems fine to me, but we should filter out the pointy brackets (< >) so that it actually imports as "Universität Mannheim" and not just "Universität "

zuphilip added some commits Nov 1, 2018

@zuphilip

This comment has been minimized.

Copy link
Collaborator

zuphilip commented Nov 1, 2018

Please have a look at the new version.

@adam3smith adam3smith merged commit 8f64313 into zotero:master Nov 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Nov 4, 2018

Great, thanks!

@zuphilip zuphilip deleted the zuphilip:labi-bw branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment