/translators

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResearchGate translator #1787

Merged
merged 1 commit into from Dec 14, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@GuyAglionby @adam3smith
@GuyAglionby
Copy link
Contributor

GuyAglionby commented Nov 26, 2018

Some changes to the ResearchGate HTML broke the detection code, so I've quickly fixed that. Some other minor changes are:

  • The way articles are listed on author pages and search results are not (any longer) the same; added a new xpath for this
  • Updated URL for downloading the abstract with the citation
  • Added support for downloading from authors who haven't registered for a RG profile (and a test for this)

Thanks!
@GuyAglionby
Fix ResearchGate translator
Verified
This commit was signed with a verified signature.
@GuyAglionby GuyAglionby Guy Aglionby
GPG key ID: 65A11B40BDE7B9B1 Learn about signing commits
Loading status checks…
dffc4fd

@adam3smith adam3smith merged commit f9de522 into zotero:master Dec 14, 2018
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Collaborator

adam3smith commented Dec 14, 2018

Looks great, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment