New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes made on the IEEE.csl file #3851

Merged
merged 6 commits into from Jan 21, 2019

Conversation

Projects
None yet
3 participants
@gsilano
Copy link
Contributor

gsilano commented Dec 31, 2018

Changes made on:

  • Added the "note" text field to the IEEE template "ieee.cls"
  • Some changes in the date format, the maximum number of authors before it appears in the text "et al." Fixed bug when mentioning a chapter in a book.
  • Added author info
  • Added "status" value. The "status" allows to specify details about the status of the paper. This is particularly useful when you use this css style in your own website (e.g., take a look at my website, giuseppesilano.net/publications.html).
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Dec 31, 2018

😟 There are some issues with your submission. Please check the test report for details.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 2, 2019

Thanks. Of these

  • we won't take the addition of "note". That doesn't make sense for the general purpose IEEE style
  • I don't think your change to the date (i.e. to always include the full date) is right. What are you basing this on?
  • Not sure what you're trying to do with chapter? chapter isn't a CSL variable. Could you say what's incorrect?
  • Where are you getting the et-al change from? I'm pretty sure 7 is in line with the IEEE guide
  • The status change looks OK to me.
@gsilano

This comment has been minimized.

Copy link
Contributor

gsilano commented Jan 2, 2019

Thanks. Of these

  • we won't take the addition of "note". That doesn't make sense for the general purpose IEEE style

It is sometimes useful when you want to add something that can not be inserted using the standard fields in the IEEE model.

  • I don't think your change to the date (i.e. to always include the full date) is right. What are you basing this on?

I have made this change to include references to my papers on my website. Therefore, in my special cases, they are useful. But perhaps these are useful in general.

  • Not sure what you're trying to do with chapter? chapter isn't a CSL variable. Could you say what's incorrect?

I needed to include the name of the chapter and the book in my reference. So, I decided to add the chapter macro.

  • Where are you getting the et-al change from? I'm pretty sure 7 is in line with the IEEE guide

Yes of course. This is a typo. On my website, I made this change to show all the authors included in the paper.

  • The status change looks OK to me.

OK. If you agree with me, I can only keep this change by removing others.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 2, 2019

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

😃 Your submission passed all our automated tests.

Show resolved Hide resolved ieee.csl Outdated
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

😃 Your submission passed all our automated tests.

adam3smith added some commits Jan 19, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 19, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 19, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 21, 2019

Thanks. I've made this a good bit more restrictive for the official IEEE style than you had in your custom version. Status will only appear for journal articles and conference papers and only when there is no issue, volume, and page number. Given the IEEE guide, the conservative use of status seems right to me. Obviously other versions can make sense for other purposes (e.g. on a personal website such as in your case).

@adam3smith adam3smith merged commit 1fbaf89 into citation-style-language:master Jan 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment