New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Scientia-Iranica #3880

Merged
merged 3 commits into from Jan 20, 2019

Conversation

Projects
None yet
4 participants
@smvazirizade
Copy link
Contributor

smvazirizade commented Jan 17, 2019

No description provided.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 17, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 17, 2019

@smvazirizade, thanks! There were several cases similar to prefix=""" suffix="," " in the style, which isn't valid XML, and which can be better handled with quotes="true", so I made that change.

@adam3smith, since the style didn't validate we should probably briefly check the output against the style guide.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 18, 2019

(style is not quite right; don't merge yet, I'll fix)

@adam3smith adam3smith self-assigned this Jan 18, 2019

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 19, 2019

😃 Your submission passed all our automated tests.

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Jan 19, 2019

@adam3smith, good to merge now? Thanks already for the fixes.

@adam3smith adam3smith merged commit 1590584 into citation-style-language:master Jan 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jan 20, 2019

Yes, sorry, got interrupted before getting to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment