Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate university-of-south-australia-2017-harvard.csl #3883
Conversation
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2019
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing. If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2019
|
adam3smith
requested changes
Jan 18, 2019
Thanks! Could you check on my two questions? Also, is https://lo.unisa.edu.au/pluginfile.php/1396048/mod_resource/content/1/HRG%20January%202017.pdf still a valid link? It doesn't work for me, but might be internal. Would |
</macro> | ||
<macro name="access-link"> | ||
<choose> | ||
<if type="article-journal book chapter" match="none"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 18, 2019
Member
Is this right, though? On https://www.library.unisa.edu.au/referencing-roadmap/electronic/e-book/ I'm seeing
Author's family name, Initial(s) OR Authoring body year, Title of ebook, edition if applicable, Publisher, Place of publication if available, .
and a book with a URL is by definition an e-book.
This comment has been minimized.
This comment has been minimized.
lachlan-young
Jan 21, 2019
Contributor
As you can see on the style page you referenced, our style has multiple rules for displaying e-book URLs. Freely available e-books show the URL, but purchased or library e-books do not (and similarly for journals). Because we can't capture this nuance within the bounds of CSL, we've decided that as the majority of e-book and journal content available in our institution is purchased/subscribed content, the default should be to not display a URL for these content types.
@@ -267,7 +265,7 @@ | |||
<label variable="page" form="short" suffix=" "/> | |||
<text variable="page"/> | |||
</macro> | |||
<macro name="access"> | |||
<macro name="access-date"> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 18, 2019
Member
I didn't look at this in detail, but it looks like not all item types that get a URL should get an access date (see e.g. the e-book example) so maybe this needs to be restricted (to blogposts and webpages perhaps?)
This comment has been minimized.
This comment has been minimized.
lachlan-young
Jan 21, 2019
Contributor
Almost all types with a URL should have an access date. The exceptions will fall into the types discussed above where we don't want to show the URL anyway. I've repositioned the logic for these types to make it clear that they affect both the access date and the URL.
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 19, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 21, 2019
|
This comment has been minimized.
This comment has been minimized.
The proposed change has been updated to address the issues identified by @adam3smith. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 21, 2019
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 21, 2019
|
adam3smith
approved these changes
Jan 21, 2019
adam3smith
merged commit 8d22e31
into
citation-style-language:master
Jan 21, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Thanks both! |
lachlan-young commentedJan 18, 2019
This update is designed to better match the style specifications for electronic access URLs, video content, titles of serials, legislation, and name particles.