Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upShould import_list() work for JSON files? #199
Comments
nathancday
changed the title
Should import_list() for JSON files?
Should import_list() work for JSON files?
Feb 3, 2019
leeper
added
the
enhancement
label
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
It's not a bug, it's just not supported for JSON. |
This comment has been minimized.
This comment has been minimized.
nathancday
commented
Feb 4, 2019
Would a PR to support JSON be welcome?
…On Mon, Feb 4, 2019 at 11:25 AM Thomas J. Leeper ***@***.***> wrote:
It's not a bug, it's just not supported for JSON.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#199 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAxVIZQSv7cZYF3J78QTJ70_6xS14pJ-ks5vKF7ngaJpZM4agYKb>
.
|
This comment has been minimized.
This comment has been minimized.
Definitely. |
This comment has been minimized.
This comment has been minimized.
nathancday
commented
Feb 4, 2019
I'm on it! Thanks for this package, it is key piece of file IO in the boxR package, which is how I stumbled upon it. Happy to do my part to support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
nathancday commentedFeb 3, 2019
This seems like a bug to me. The docs for
?import_list
say the return value should be a list, "If rbind=FALSE (the default), a list of a data frames. "Here is a smol reprex.
Created on 2019-02-03 by the reprex package (v0.2.1)
In building this out I found that
rio::export(list_obj, "tst2.json")
raises an error and think that may be related. The docs forexport
say "An exception to this is that x can be a list of data frames if the output file format is an Excel .xlsx workbook, .Rdata file, or HTML file. See examples.)" and my feeling is that JSON files should be included in these exceptions.