Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade rails: 5.1.6.1 → 5.2.2 (minor) #228
Conversation
depfu
bot
added
the
depfu
label
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
@depfu rebase |
depfu
bot
force-pushed the
depfu/update/rails-5.2.2
branch
from
bd30e8e
to
dd072e0
Dec 11, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 11, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 92.49% 92.49%
=======================================
Files 35 35
Lines 533 533
=======================================
Hits 493 493
Misses 40 40 Continue to review full report at Codecov.
|
ruebot
approved these changes
Dec 11, 2018
Pretty thorough local testing, and everything looks good. |
ruebot
merged commit 07df9f4
into
master
Dec 11, 2018
depfu
bot
deleted the
depfu/update/rails-5.2.2
branch
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedDec 11, 2018
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
5.2.2
Active Support
Fix bug where
#to_options
forActiveSupport::HashWithIndifferentAccess
would not act as alias for
#symbolize_keys
.Nick Weiland
Improve the logic that detects non-autoloaded constants.
Jan Habermann, Xavier Noria
Fix bug where
URI.unescape
would fail with mixed Unicode/escaped character input:Ashe Connor, Aaron Patterson
Active Model
Fix numericality validator to still use value before type cast except Active Record.
Fixes #33651, #33686.
Ryuta Kamizono
Active Record
Do not ignore the scoping with query methods in the scope block.
Ryuta Kamizono
Allow aliased attributes to be used in
#update_columns
and#update
.Gannon McGibbon
Allow spaces in postgres table names.
Fixes issue where "user post" is misinterpreted as ""user"."post"" when quoting table names with the postgres
adapter.
Gannon McGibbon
Cached columns_hash fields should be excluded from ResultSet#column_types
PR #34528 addresses the inconsistent behaviour when attribute is defined for an ignored column. The following test
was passing for SQLite and MySQL, but failed for PostgreSQL:
Dmitry Tsepelev
Values of enum are frozen, raising an error when attempting to modify them.
Emmanuel Byrd
update_columns
now correctly raisesActiveModel::MissingAttributeError
if the attribute does not exist.
Sean Griffin
Do not use prepared statement in queries that have a large number of binds.
Ryuta Kamizono
Fix query cache to load before first request.
Eileen M. Uchitelle
Fix collection cache key with limit and custom select to avoid ambiguous timestamp column error.
Fixes #33056.
Federico Martinez
Fix duplicated record creation when using nested attributes with
create_with
.Darwin Wu
Fix regression setting children record in parent
before_save
callback.Guo Xiang Tan
Prevent leaking of user's DB credentials on
rails db:create
failure.bogdanvlviv
Clear mutation tracker before continuing the around callbacks.
Yuya Tanaka
Prevent deadlocks when waiting for connection from pool.
Brent Wheeldon
Avoid extra scoping when using
Relation#update
that was causing this method to change the current scope.Ryuta Kamizono
Fix numericality validator not to be affected by custom getter.
Ryuta Kamizono
Fix bulk change table ignores comment option on PostgreSQL.
Yoshiyuki Kinjo
Action View
Action Pack
Reset Capybara sessions if failed system test screenshot raising an exception.
Reset Capybara sessions if
take_failed_screenshot
raise exceptionin system test
after_teardown
.Maxim Perepelitsa
Use request object for context if there's no controller
There is no controller instance when using a redirect route or a
mounted rack application so pass the request object as the context
when resolving dynamic CSP sources in this scenario.
Fixes #34200.
Andrew White
Apply mapping to symbols returned from dynamic CSP sources
Previously if a dynamic source returned a symbol such as :self it
would be converted to a string implicity, e.g:
would generate the header:
and now it generates:
Andrew White
Fix
rails routes -c
for controller name consists of multiple word.Yoshiyuki Kinjo
Call the
#redirect_to
block in controller context.Steven Peckins
Active Job
Make sure
assert_enqueued_with()
&assert_performed_with()
work reliably with hash arguments.Sharang Dashputre
Restore
ActionController::Parameters
support toActiveJob::Arguments.serialize
.Bernie Chiu
Restore
HashWithIndifferentAccess
support toActiveJob::Arguments.deserialize
.Gannon McGibbon
Include deserialized arguments in job instances returned from
assert_enqueued_with
andassert_performed_with
Alan Wu
Increment execution count before deserialize arguments.
Currently, the execution count increments after deserializes arguments.
Therefore, if an error occurs with deserialize, it retries indefinitely.
Yuji Yaginuma
Action Mailer
Action Cable
Active Storage
Support multiple submit buttons in Active Storage forms.
Chrıs Seelus
Fix
ArgumentError
when uploading to amazon s3Hiroki Sanpei
Add a foreign-key constraint to the
active_storage_attachments
table for blobs.George Claghorn
Discard
ActiveStorage::PurgeJobs
for missing blobs.George Claghorn
Fix uploading Tempfiles to Azure Storage.
George Claghorn
Railties
Disable content security policy for mailer previews.
Dylan Reile
Log the remote IP address of clients behind a proxy.
Atul Bhosale
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by 52 commits:
Prepare for 9.0.0
Merge pull request #501 from abelards/patch-1
Merge pull request #502 from kddeisz/count-math
Allow count nodes to have math functions
Update README.md
Merge pull request #500 from jcoleman/fix_incorrect_typecasting_of_raw_sql_strings
Type-castable attributes should not try to cast SqlLiteral nodes
Merge pull request #496 from amatsuda/froms_to_nowhere
Merge pull request #499 from jgraichen/jg/cte-bindparams
Support BindParams in subqueries
Merge pull request #498 from yhirano55/update_travis
Update .travis.yml
Unused variables
Merge pull request #495 from koic/add_required_ruby_version_to_gemspec
Update travis.yml
Add required_ruby_version to gemspec
Merge pull request #494 from koic/remove_encoding_utf8_magic_comment
Remove encoding utf-8 magic comment
Merge pull request #493 from gaurish/patch-1
Remove Unused variable - offset_bind
Merge pull request #492 from mikaji/ci_against_2.4.1
Merge pull request #491 from yahonda/follow_up_add_bind_for_oracle_visitor
CI against 2.4.1
Address `undefined method `value_for_database'` in Oracle visitor
Change the verison to 9.0.0.alpha
Merge pull request #490 from MaxLap/fix_nodes_hash_eql_eqeq
Add missing hash, eql?, == to various node classes
Merge pull request #489 from kamipo/remove_unused_bind_values
Remove unused `bind_values`
Fix test failures
Adjust `BindParam` as needed for AR
Add a collector to grab the bind values off the AST
Ensure `ToSql` collector returns a UTF-8 string
Refactor `substitute_binds` to perform substitution immediately
Add a value field `Nodes::BindParam`
Rename `Collectors::Bind`
Merge pull request #484 from kirs/multiple-insert-v2
Merge pull request #472 from film42/master
Test concurrency of visitor superclass fallback
Support INSERT with multiple values
Merge pull request #483 from kamipo/remove_unused_engine
Add regression test
Revert "Merge pull request #482 from kirs/multiple-insert"
Merge pull request #482 from kirs/multiple-insert
Remove unused `engine`
Support multiple inserts
Merge pull request #475 from PedroSena/chainable-insert
Made InsertManager#insert chainable
Merge pull request #474 from JaKXz/patch-1
docs(distinct): tweaks [skip ci]
docs(distinct): fix distinct example [skip ci]
docs: add distinct to README
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Commits
See the full diff on Github. The new version differs by 17 commits:
Fix the version of Rubygems that Travis is using on Ruby 1.9.
Bump version to 0.7.0.
Refactor the client examples, and get the TCPSocket one into a runnable state so it can be run from the command line with a URI.
Don't require rubygems, this has not been necessary since Ruby 1.8.
Merge pull request #53 from izwick-schachter/master
Added TCPSocket client example
Rename tcp_server.rb to em_server.rb.
Add an example EventMachine client.
Flesh out the docs for the new ping/pong events.
Make the ping/pong tests check the content of the events.
Emit ping and pong events after all other effects of those frames have been carried out.
Merge pull request #51 from ably-forks/support-ping-in-event-emitter
Update Ruby versions in Travis config.
Update docs to reflect ping & pong events
Emit :ping and :pong events in the driver
Merge pull request #50 from junaruga/feature/travis-ruby-head
Update Ruby 2.3, 2.4 to latest version on Travis.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands