New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Libgen translator URL detection #1255

Merged
merged 2 commits into from Mar 11, 2017

Conversation

Projects
None yet
2 participants
@owcz
Copy link
Contributor

owcz commented Mar 11, 2017

See examples—order was switched in URL detection

Typo in Libgen translator URL detection
See examples—order was switched in URL detection
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 11, 2017

thanks -- could you please add a test from the gen.lib.... domain (or substitute one of the libgen.io one)?

@adam3smith adam3smith merged commit ccaa082 into zotero:master Mar 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Mar 11, 2017

Thanks!

@owcz owcz deleted the owcz:patch-4 branch Mar 13, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Typo in Libgen translator URL detection (zotero#1255)
* add Libgen example in tests, per review

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Typo in Libgen translator URL detection (zotero#1255)
* add Libgen example in tests, per review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment