Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd license and other requirements for CRAN #20
+25
−78
Conversation
This comment has been minimized.
This comment has been minimized.
This version has been submitted to CRAN as archivr-0.0.1. Once this is merged, I will push a release to complete the project. |
adam3smith
reviewed
Feb 5, 2019
LICENSE
Outdated
@@ -0,0 +1,19 @@ | |||
#' Copyright <2019> <Qualitative Data Repository, Syracuse University> |
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 5, 2019
Contributor
Any reason you're using the #' roxygen
comments? Since this is in a separate file, the license can just be plain text, no?
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
adam3smith
Feb 5, 2019
Contributor
Will it mess with your CRAN submission if I take these out? Otherwise this is good to go.
This comment has been minimized.
This comment has been minimized.
greebie
Feb 5, 2019
Collaborator
No I don't think so. Once it's accepted (or not) I can repair it accordingly.
adam3smith
merged commit 0dcf54c
into
master
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
greebie commentedFeb 5, 2019
Some minor changes to set up for cran (e.g. add documentation for default).