Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdating/adding additional Slack links,closes #213 #242
+11
−4
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 8, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
======================================
Coverage 92.2% 92.2%
======================================
Files 35 35
Lines 539 539
======================================
Hits 497 497
Misses 42 42Continue to review full report at Codecov.
|
ianmilligan1
requested review from
ruebot
and
SamFritz
and removed request for
ruebot
Jan 8, 2019
SamFritz
approved these changes
Jan 8, 2019
This looks great @ianmilligan1, thanks so much for the updates. Just one smallsuggestion
| @@ -95,5 +96,10 @@ | |||
| <p class="about_p">You can further interact with the hyperlink diagram by hovering over any node to highlight its immediate connections to other nodes. The arrow on each line indicates the direction of connection, for instance, in the image below, we see an arrow connecting two nodes and reveals the townyarmouth.ca has a link to the atlantic.ctvnews.ca domain. </p> | |||
| <%= image_tag("AUK_neighbours.png", alt: "AUK Interactive Hyperlink Diagram Explained", class:"body_img")%> | |||
| <%= image_tag("AUK_hover.png", alt: "AUK Interactive Hyperlink Diagram hover feature", class:"body_img")%> | |||
|
|
|||
| <h3 class="about_h3">Need More Help?</h3> | |||
| <p class="about_p">Is your question or issue not discussed above? We'd love to hear more. Please join our <%= link_to('Slack channel', 'http://slack.archivesunleashed.org', target: '_blank') %> (the #auk-support channel is dedicated to these queries!) or check out the <%= link_to('"get involved"', 'https://archivesunleashed.org/get-involved/', target: '_blank') %> section of our website.</p> | |||
This comment has been minimized.
This comment has been minimized.
ruebot
merged commit 438381a
into
master
Jan 8, 2019
ruebot
deleted the
issue-213
branch
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedJan 8, 2019
GitHub issue(s):
#213
What does this Pull Request do?
This is a relatively straightforward pull request. It changes any existing Slack signups links from the Google Doc to the new one at http://slack.archivesunleashed.org. It also adds a few more references to this, noting the #auk-support channel, so that people know that they can join our Slack group for any support queries.
It also updates the e-mail address from gmail to archivesunleashed. Given the general tenor of #213, I think this was in scope.
How should this be tested?
Travis should turn Green.
@SamFritz and @ruebot should review text to make sure I haven't added any typos, that the prose and instructions make sense, and that I haven't broken any HTML.
Interested parties
@SamFritz @ruebot