Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upIssue 259: Impliment Table of Contents #264
+179
−39
Conversation
SamFritz
added some commits
Feb 7, 2019
SamFritz
added
ux
design
style
labels
Feb 8, 2019
SamFritz
self-assigned this
Feb 8, 2019
SamFritz
requested review from
ruebot
and
ianmilligan1
Feb 8, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 8, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
=======================================
Coverage 96.39% 96.39%
=======================================
Files 35 35
Lines 555 555
=======================================
Hits 535 535
Misses 20 20Continue to review full report at Codecov.
|
| <li class="toc-li"><%=link_to('What Can We Learn From Sentiment Analysis?', anchor: '5toc') %></li> | ||
| </ul> | ||
| </div> | ||
| <br> |
This comment has been minimized.
This comment has been minimized.
| @@ -268,6 +268,50 @@ body { | |||
| padding: 15px; | |||
| text-align:left; | |||
| } | |||
| /* | |||
| * AUK Derivative Pages - table of contents customization | |||
This comment has been minimized.
This comment has been minimized.
| margin-left: 20px; | ||
| margin-top: 5px; | ||
| margin-bottom: 5px; | ||
| } |
This comment has been minimized.
This comment has been minimized.
| line-height: 1.4; | ||
| margin-left: 20px; | ||
| margin-right: 25px; | ||
| } |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks for taking a look @ruebot! I’ll make implement those changes. |
ianmilligan1
approved these changes
Feb 9, 2019
|
This looks great. Tested locally and all the headers and back to tops are working well. Great work @SamFritz! |
ruebot
approved these changes
Feb 9, 2019
ruebot
merged commit 3a51eac
into
master
Feb 9, 2019
ruebot
deleted the
issue-259toc
branch
Feb 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SamFritz commentedFeb 8, 2019
This PR adds in a table of contents (toc) for each learning guide. This implementation is a result of feedback from a user survey.
**GitHub Issues: 259: AUK Documentation - Impliment ToC
What does this Pull Request do?
Work complete includes:
How should this be tested?
Has been tested on safari and google chrome locally and renders without issue.
Additional Notes:
Please feel free to provide feedback on style and testing :)
Interested parties
@ruebot @ianmilligan1
Thanks in advance for your help with the Archives Unleashed Toolkit!