/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize license headers; resolves #51. #55

Closed
wants to merge 2 commits into
base: master
from
+274 −158

Conversation

Reviewers

@ianmilligan1 ianmilligan1

@greebie greebie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
@ruebot
Member

ruebot commented Sep 4, 2018

GitHub issue(s): #51

What does this Pull Request do?

  • Update license header in all src files.
  • Update README
  • Rename LICENSE.txt to LICENSE
  • Make LICENSE consistent with other AU projects

How should this be tested?

GraphPass should build fine, and work as currently expected.

Additional Notes:

I updated the Acknowledgments section in the README since it looked like a straight copy of aut. @ianmilligan1 let me know if you're good with the edits there.
@ruebot
Normalize license headers; resolves #51. 
- Update license header in all src files.
- Update README
- Rename LICENSE.txt to LICENSE
- Make LICENSE consistent with other AU projects
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
02e3384

@ruebot ruebot requested review from greebie and ianmilligan1 Sep 4, 2018

@ianmilligan1

ianmilligan1 requested changes Sep 5, 2018
View changes

Looks great, headers are nice (and builds and works fine).

Only requested change is minor one to the acknowledgments since we're updating those.

Show outdated Hide outdated README.md
@ruebot
<empty>
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
73062d3
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 5, 2018

Member

I'm going to close this, and create a new PR for this to get TravisCI and CodeCov to theoretically trigger together.
Member

ruebot commented Sep 5, 2018

I'm going to close this, and create a new PR for this to get TravisCI and CodeCov to theoretically trigger together.

@ruebot ruebot closed this Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment