New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update journal-of-historical-linguistics.csl #2562

Merged
merged 3 commits into from Mar 15, 2017

Conversation

Projects
None yet
4 participants
@POBrien333
Copy link
Contributor

POBrien333 commented Mar 10, 2017

via error request: https://forums.zotero.org/discussion/comment/271743/#Comment_271743
It should come out as In Hall PA & Soskice D, eds., (comma between names and label), but comes out as In Hall PA & Soskice D eds.,

Am I missing something?

Update journal-of-historical-linguistics.csl
https://forums.zotero.org/discussion/comment/271743/#Comment_271743 
It should come out as In Hall PA & Soskice D, eds., (comma between names and label), but comes out as
In Hall PA & Soskice D eds.,
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 10, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 10, 2017

😃 Your submission passed all our automated tests.

1 similar comment
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 10, 2017

😃 Your submission passed all our automated tests.

@adam3smith
Copy link
Member

adam3smith left a comment

Thanks! I just went by a couple of examples, so let me know if there are other examples to the contrary and we can figure out together which make most sense in the context of the style

@@ -28,7 +28,7 @@
</macro>
<macro name="author">
<names variable="author">
<name delimiter-precedes-last="always" initialize="false" initialize-with="." name-as-sort-order="all" sort-separator=" "/>
<name delimiter-precedes-last="always" initialize="false" initialize-with="." name-as-sort-order="first"/>

This comment has been minimized.

@adam3smith

adam3smith Mar 11, 2017

Member

this should have and="symbol"

<group prefix=" " suffix=".">
<text term="in" text-case="capitalize-first" suffix=" "/>
<names variable="editor translator" delimiter="," suffix=",">
<name delimiter=" " and="symbol" delimiter-precedes-last="always" initialize-with="" name-as-sort-order="all" sort-separator=" "/>

This comment has been minimized.

@adam3smith

adam3smith Mar 11, 2017

Member

I'm not seeing initials in the bibliographies, so remove initialize-with="". I also see names in regular order, so remove the name-as-sort-order. Finally, I'm not seeing a comma before the ampersand, so set delimiter-precedes-last="never"
I'm working off this example:
image
Might also be there are different ones? But this makes sense in the context of the style

This comment has been minimized.

@adam3smith

adam3smith Mar 11, 2017

Member

That same example also suggests that there shouldn't be an "in" and that the label should be before the name and be verb-short.

<text variable="container-title" prefix=" " suffix="." font-style="italic"/>
<text macro="publisher" prefix=" " suffix=", "/>
<text variable="page" suffix="."/>
<text variable="page" prefix=" " suffix="."/>

This comment has been minimized.

@adam3smith

adam3smith Mar 11, 2017

Member

it looks like we're missing the publisher macro here now?

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Mar 11, 2017

It should come out as In Hall PA & Soskice D, eds., (comma between names and label), but comes out as In Hall PA & Soskice D eds.,

Am I missing something?

You'd have to change the "label" element in

        <else-if type="chapter paper-conference" match="any">
          <text macro="title" prefix=" "/>
          <group prefix=".">
            <group>
              <group prefix=" " suffix=".">
                <text term="in" text-case="capitalize-first" suffix=" "/>
                <names variable="editor translator" delimiter="," suffix=",">
                  <name delimiter=" " and="symbol" delimiter-precedes-last="always" initialize-with="" name-as-sort-order="all" sort-separator=" "/>
                  <label form="short" prefix=" "/>
                </names>
                <text variable="page" prefix=" " suffix="."/>
              </group>
            </group>
          </group>
        </else-if>

to <label form="short" prefix=", "/>.

@POBrien333

This comment has been minimized.

Copy link
Contributor Author

POBrien333 commented Mar 13, 2017

Thanks for reviewing this style. That chapter section was completely messed up. sorry.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Mar 13, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit 6854027 into citation-style-language:master Mar 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Mar 15, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment