/styles

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harvard-coventry-university.csl #2654

Merged
merged 5 commits into from May 5, 2017

Conversation

Reviewers

@rmzelle rmzelle

@adam3smith adam3smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Elbar914 @csl-bot @adam3smith @rmzelle
@Elbar914
Copy link
Contributor

Elbar914 commented Apr 26, 2017

From EasyBib: A user reported that when she cites websites like https://www.nice.org.uk/guidance/cg181/chapter/1-Recommendations#lipid-modification-therapy-for-the-primary-and-secondary-prevention-of-cvd-2 in Harvard - Coventry University, "anon" is showing up as the author for each one. I'm not finding that listed in any author or contributor tags in the page source, and when I cite a different web URL in Harvard CU and remove the author, "anon" shows up. CU says this is not correct.

Fix: remove "anon" from website citations with no author in Harvard CU
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 26, 2017

Awesome! You've created a pull request to the Citation Styles Language styles repository. We'll get in touch soon (usually within a day or two). In the meantime, our automated test system will go ahead and run some checks on your pull request. In a few minutes you'll be notified of the test results.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update the current pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

image

If you need assistance at any point, please leave a comment and we'll get back to you (feel free to write in Dutch, English, French, German, Portuguese, or Spanish).
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Apr 26, 2017

I guess you've talked to the university, but here's what they actually write (guide linked to from http://www.coventry.ac.uk/study-at-coventry/student-support/academic-support/centre-for-academic-writing/support-for-students/academic-writing-resources/cu-harvard-reference-style-guide/ ):
image
It seems to me that's exactly what the style is doing.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented Apr 26, 2017

😟 There are some issues with your submission. Please check the test report for details.
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented Apr 26, 2017

@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented Apr 26, 2017

If you could check back with them -- we can certainly change this (though it seems like we may want to go with "title" and not "container-title" given the text? Also, definitely not in quotes from the looks of it.
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented Apr 26, 2017

@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 1, 2017

@adam3smith

adam3smith reviewed May 1, 2017
View changes

harvard-coventry-university.csl Outdated
@@ -98,7 +97,7 @@
<label form="short" prefix=" " strip-periods="false"/>
<substitute>
<text macro="editor"/>
<text macro="anon"/>
<text variable="container-title" text-case="title" quotes="true" font-style="normal" text-decoration="none"/>

This comment has been minimized.

Sign in to view
Copy link
@adam3smith

adam3smith May 1, 2017

Member

given the response you received, you'll want to use <text variable="title"/> here, not container-title. ditto below.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented May 1, 2017

😟 There are some issues with your submission. Please check the test report for details.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented May 1, 2017

You'll need to deleted the anon macro now that it's not used anymore.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented May 1, 2017

😃 Your submission passed all our automated tests.
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 1, 2017

Thanks for your help.
@adam3smith

This comment has been minimized.

Sign in to view
Copy link
Member

adam3smith commented May 2, 2017

sorry, one more question -- the quotes you're putting around the title in those cases, are those based on something you're getting from the University, too? Because I don't see those in the styleguide.
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 2, 2017

I believe it depends on the source type. Journal articles get single quotation marks, while books, websites, journals should be in italics.
@adam3smith
Clean up substitute
Loading status checks…
25fec26
@rmzelle

rmzelle reviewed May 2, 2017
View changes

harvard-coventry-university.csl Outdated
@@ -284,7 +280,7 @@
<layout prefix="(" suffix=")" delimiter=", ">
<choose>
<if locator="page">
<group delimiter=":&#160;">
<group delimiter=": ">

This comment has been minimized.

Sign in to view
Copy link
@rmzelle

rmzelle May 2, 2017

Member

@adam3smith, before you merge this, we might want to make certain these non-breaking spaces are still there, and escape them.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented May 2, 2017

😃 Your submission passed all our automated tests.
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 5, 2017

Anything else you need from me?
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented May 5, 2017

@Elbar914, I assume you didn't actually mean to make any changes to the non-breaking spaces in the original file, right?
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 5, 2017

I did not, no.
@csl-bot

This comment has been minimized.

Sign in to view
Copy link

csl-bot commented May 5, 2017

😃 Your submission passed all our automated tests.

@rmzelle rmzelle merged commit ab25131 into citation-style-language:master May 5, 2017
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmzelle

This comment has been minimized.

Sign in to view
Copy link
Member

rmzelle commented May 5, 2017

Okay, it was a bit hard to tell whether those special spaces were converted to regular spaces, or just 'unescaped', but I just put back the escaped non-breaking space codes. I think we were all set otherwise, thanks!
@Elbar914

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

Elbar914 commented May 5, 2017

Thanks so much!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment