Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdated the AMA base style to properly reference presentations #3274
Conversation
added some commits
Jan 17, 2018
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.
If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
|
|
adam3smith
reviewed
Jan 18, 2018
| @@ -215,6 +219,20 @@ | |||
| <else-if type="webpage"> | |||
| <text variable="container-title" prefix=" " suffix="."/> | |||
| </else-if> | |||
| <else-if type="speech"> | |||
| <group delimiter=" "> | |||
| <text variable="genre" prefix=" " suffix=" presented at:"/> | |||
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 18, 2018
Member
please use <text term="presented at" suffix=":"/> instead to keep the style localizable to non-English.
We should also think about some different scenarios here, i.e. what if genre is not present? What if event is missing (less likely)
This comment has been minimized.
This comment has been minimized.
danwchan
Jan 18, 2018
Author
Contributor
Ah yes I hadn't considered the different cases of omitted information. There is no AMA recommendation in these cases but I suppose we can exercise some judgement to make it fail more gracefully. I'll edit this with these considerations and your other suggestion regarding non-English.
This comment has been minimized.
This comment has been minimized.
adam3smith
Jan 18, 2018
Member
Exactly, just make sure it looks reasonable, especially when genre is missing, as it often will.
added some commits
Jan 18, 2018
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 18, 2018
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 19, 2018
|
|
This comment has been minimized.
This comment has been minimized.
csl-bot
commented
Jan 19, 2018
|
|
adam3smith
merged commit ebe9d33
into
citation-style-language:master
Jan 19, 2018
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Thanks -- I simplified the logic for presentations without event a bit more (note, btw., that you cannot use random terms, they need to be in the specifications) |
This comment has been minimized.
This comment has been minimized.
|
Mmm yeah I realized that as I was familiarizing myself with CSL more. The failure case where the conference name is omitted isn't graceful in my opinion. It leaves the Thanks for all your help. |
danwchan commentedJan 18, 2018
speechis the CSL type which seems most fitting for orally presented work at a conference.genreholds the type presented. The AMA style guide gives examples of types as "posters" or "papers".event,event-placeanddatehold the name, location and date of the conference.an example of a properly rendered presentation from the AMA style guide: