New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brain.csl #3626

Merged
merged 2 commits into from Jul 28, 2018

Conversation

Projects
None yet
4 participants
@115zed81
Copy link
Contributor

115zed81 commented Jul 26, 2018

Multiple publications of an author during the same year are now labelled a, b, c...etc, as detailed in Brain Instruction for authors

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 26, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 26, 2018

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 26, 2018

Thanks!
I don't see, though, how this change does what you say. disambiguate-add-year-suffix="true" is already in the existing style. Your changes make this less likely to appear and change the collapsing rules (from Smith 2015a, 2015b to Smith 2015a, b).

If you have any indication (e.g. published articles, author guidelines) that the collapse change is right, I'm happy to take that, but I don't think the rest makes sense here.

@adam3smith adam3smith closed this Jul 26, 2018

@115zed81

This comment has been minimized.

Copy link
Contributor Author

115zed81 commented Jul 26, 2018

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 26, 2018

perfect, thanks -- we'll put that in

@adam3smith adam3smith reopened this Jul 26, 2018

@115zed81

This comment has been minimized.

Copy link
Contributor Author

115zed81 commented Jul 26, 2018

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 26, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jul 28, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 6947ac1 into citation-style-language:master Jul 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 28, 2018

thanks!

@115zed81

This comment has been minimized.

Copy link
Contributor Author

115zed81 commented Jul 30, 2018

Hi, when will the updated brain.csl file be actually available in Zotero repository? I have just dowloaded the file but no changes appear. Thanks

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Jul 30, 2018

it's up. Have you tried in a new document? And there's no need to download anything. Just click "Update now" from Zotero.

@115zed81

This comment has been minimized.

Copy link
Contributor Author

115zed81 commented Jul 30, 2018

@rmzelle

This comment has been minimized.

Copy link
Member

rmzelle commented Aug 5, 2018

I tried in a new document and something went wrong with updating, since brain.csl does exactly the same "error".

Let us know if you still have problems getting access to the updated style. I just checked and the version in the Zotero Style Repository is definitely up-to-date with the changes we made here.

@115zed81

This comment has been minimized.

Copy link
Contributor Author

115zed81 commented Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment