Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjust JSON handling to be like RDS #200
+44
−15
Conversation
nathancday
force-pushed the
nathancday:master
branch
from
b9c5e51
to
5d705bb
Feb 9, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Feb 9, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 18 18
Lines 861 861
=======================================
Hits 706 706
Misses 155 155
Continue to review full report at Codecov.
|
nathancday
force-pushed the
nathancday:master
branch
from
5d705bb
to
25b8546
Feb 9, 2019
This comment has been minimized.
This comment has been minimized.
|
On glance, this looks good. Will examine more closely a little later. Thanks! |
leeper
added
the
enhancement
label
Feb 11, 2019
leeper
merged commit 25b8546
into
leeper:master
Feb 11, 2019
added a commit
that referenced
this pull request
Feb 11, 2019
nathancday
referenced this pull request
Feb 11, 2019
Closed
Trouble for box_read() with JSON files #86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nathancday commentedFeb 9, 2019
After digging into the code I pivoted to adjusting handling of JSON file formats in
import()andexport()instead of inimport_list(). My thought process was that because the underlyingjsonlitefunctions don't have a which/itemizer to specify a sub unit , like XLS sheets, nor are the objects saved in itemized way likeRdata, theimport_list()function didn't really fit. But sincetoJSON()andfromJSON()already handle a variety of R object classes I figured the current pattern forRDSobjects was most similar to the concept ofjsonlite. I realize this is a detour from the original issue I raised about import JSON lists #199 but it seems to fit with issue #183. Thoughts?