New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create journal-of-transport-history.csl #3896

Merged
merged 6 commits into from Feb 12, 2019

Conversation

Projects
None yet
3 participants
@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 29, 2019

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 29, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Jan 29, 2019

😃 Your submission passed all our automated tests.

@POBrien333 POBrien333 changed the title WIP: Create journal-of-transport-history.csl Create journal-of-transport-history.csl Feb 12, 2019

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Feb 12, 2019

This should be fine now.
Publisher moved from numeric to note style. Current publications (Jan-19) still don't follow that guide, but the guidelines from 2018 were announced as new.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 12, 2019

😟 There are some issues with your submission. Please check the test report for details.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 12, 2019

😃 Your submission passed all our automated tests.

@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Feb 12, 2019

@POBrien333 check out the changes on the ibid/subsequent: because of how they evaluate, you always want ibid-with-locator, ibid, and subsequent in the order they are now. Everything that's ibid-with-locator is also ibid and everything that's ibid is also subsequent, so if you start with subsequent, you never get to the ibid conditions.

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 12, 2019

😃 Your submission passed all our automated tests.

@POBrien333

This comment has been minimized.

Copy link
Contributor

POBrien333 commented Feb 12, 2019

Ah great! Thank you. Wasn't aware of that! Thanks for the fixes!

@csl-bot

This comment has been minimized.

Copy link

csl-bot commented Feb 12, 2019

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 063f0bd into citation-style-language:master Feb 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Member

adam3smith commented Feb 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment