Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd test coverage for display_domains and filtered text path helpers. #254
+959
−16
Conversation
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 24, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 94.49% 96.37% +1.87%
==========================================
Files 35 35
Lines 545 551 +6
==========================================
+ Hits 515 531 +16
+ Misses 30 20 -10
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
@ianmilligan1 here's another |
ianmilligan1
approved these changes
Jan 24, 2019
ianmilligan1
merged commit eb39de9
into
archivesunleashed:master
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedJan 24, 2019
Here we go again creating more tests.