Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign up[ruby] Upgrade rubocop to version 0.63.0 #59
Conversation
depfu
bot
added
the
depfu
label
Jan 17, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Jan 17, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 34 34
=====================================
Hits 34 34 Continue to review full report at Codecov.
|
ruebot
approved these changes
Jan 17, 2019
ruebot
merged commit b43c0d9
into
master
Jan 17, 2019
depfu
bot
deleted the
depfu/update/rubocop-0.63.0
branch
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
depfu bot commentedJan 17, 2019
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
Release Notes
0.63.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 45 commits:
Cut 0.63
[Fix #6673] Fix `Style/DocumentationMethod` for inline `module_function`
[Fix #6575] Fix `Naming/PredicateName` cop suggesting invalid rename
[Fix #6633] Fix `Lint/SafeNavigation` complaining about use of `to_d`
[Fix #6627] Fixes regression in heredoc identification for Style/TrailingCommaInArguments
[Fix #6670] Fix a false positive for `Style/SafeNavigation`
Merge pull request #6584 from roooodcastro/add-ignore-disable-comments
Merge branch 'master' into add-ignore-disable-comments
Fix a typo in CHANGELOG.md
In Rails >= 5, use optional: true, not required: false
Merge pull request #6666 from rubocop-hq/revert-pr-6596
Revert "In Rails >= 5, use optional: true, not required: false (#6596)"
Revert "Fix Lint/AmbiguousBlockAssociation cites unambiguous lambda (#6650)"
Improve CLI usage message for --stdin option (#6607)
In Rails >= 5, use optional: true, not required: false (#6596)
[Fix #6150] Add runtime option to ignore cop disable comments
Fix Lint/AmbiguousBlockAssociation cites unambiguous lambda (#6650)
[Fix #6651] Make Style/RegexpLiteral auto-correct correctly replace inner slashes (#6652)
[Fix #6586] Add DisjunctiveAssignmentInConstructor
[Fix #6363] Allow `Style/YodaCondition` cop to be configured to enforce yoda conditions
Add autocorrect to Rails/LinkToBlank (#6604)
Fix grammar
Update configuration.md
[Fix #4460] Improve TernaryParentheses#unparenthesized_method_call?
Add new `Rails/IgnoredSkipActionFilterOption` cop
Abandon making frozen-string-literals default for Ruby 3.0
Merge pull request #6656 from rrosenblum/fix_changelog
Merge duplicate Changes sections in CHANGELOG
Fix broken omit parens reports in assignments
Fix missing parens omission reports in conditions with operators
Move `FlipFlop` cop from `Style` to `Lint` department
Add an example of compact left braces to SpaceInsideHashLiteralBraces
Modify example code to not contain offenses
[Fix #6641] Specify `Performance/RangeInclude` as unsafe
[Fix #6625] Update the changelog
Revert "[Fix #595] Exclude files ignored by `git`"
Add new RangeNode extension
[Fix #6617] Prevent traversal error on infinite ranges
Tweak document and message for `Style/FlipFlop` cop
Merge pull request #6565 from tatsuyafw/bugfix/shadowed-exception
[Fix #6526] Fix a wrong line highlight in `Lint/ShadowedException` cop
Fix heredoc detection in trailing comma (#6623)
[Fix #6100] Fix a false positive in `Naming/ConstantName` cop
[Fix #6624] Use older RubyGems & Bundler on Windows (#6628)
Update Copyright year to 2019
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands