New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: dlmmc: Dynamical linear model regression for atmospheric time-series analysis #1140

Closed
whedon opened this Issue Dec 22, 2018 · 37 comments

Comments

Projects
None yet
8 participants
@whedon
Collaborator

whedon commented Dec 22, 2018

Submitting author: @justinalsing (Justin Alsing)
Repository: https://github.com/justinalsing/dlmmc
Version: v1.0.0
Editor: @danielskatz
Reviewers: @Chilipp, @taqtiqa-mark

Author instructions

Thanks for submitting your paper to JOSS @justinalsing. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@justinalsing if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

@whedon whedon added the pre-review label Dec 22, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 22, 2018

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 22, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 22, 2018

PDF failed to compile for issue #1140 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/author.rb:58:in block in build_affiliation_string': Problem with affiliations for Justin Alsing, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/author.rb:57:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/author.rb:57:in build_affiliation_string' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/author.rb:17:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon.rb:109:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon.rb:109:in block in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon.rb:106:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon.rb:106:in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon.rb:73:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/processor.rb:32:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/bin/whedon:52:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-443822f01563/bin/whedon:113:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Dec 28, 2018

@whedon generate pdf

@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 28, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 28, 2018

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Dec 28, 2018

@whedon assign @danielskatz as editor

@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 28, 2018

OK, the editor is @danielskatz

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Dec 28, 2018

👋 @justinalsing - I note that you don't have DOIs in the references for papers - you can add them to the bib file, then rebuild the PDF by adding a comment here that just says

@whedon generate pdf

Also, do you have suggestions for reviewers? In particular, this list of people have already agreed to review for JOSS and may be suitable for this submission, though if you have suggestions outside the list, that's great too.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Dec 28, 2018

Also, as we get this started, please be aware of the review criteria that will be used, and make any other changes needed to make the review easier.

@justinalsing

This comment has been minimized.

justinalsing commented Dec 30, 2018

@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 30, 2018

Attempting PDF compilation. Reticulating splines etc...
@whedon

This comment has been minimized.

Collaborator

whedon commented Dec 30, 2018

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 2, 2019

👋 @justinalsing - I am still hoping for suggestions for reviewers from you. In particular, this list of people have already agreed to review for JOSS and may be suitable for this submission, though if you have suggestions outside the list, that's great too.

@justinalsing

This comment has been minimized.

justinalsing commented Jan 3, 2019

Hi @danielskatz

I did a quick search through the list of reviewers for people with expertise in python, time-series analysis, and (bayesian) statistics, and came up with this short-list

ejolly
ghammad
taqtiqa-mark
lindemann09

That's probably a sensible place to start, I'll let you know if I come up with any more/better suggestions

Thanks,
Justin

@justinalsing

This comment has been minimized.

justinalsing commented Jan 3, 2019

Other possible suitable reviewers (expertise in python and climate science)

jtmiclat
Chilipp
sarats

@justinalsing

This comment has been minimized.

justinalsing commented Jan 3, 2019

I was also recommended mathause (not on the list of JOSS reviewers) by a colleague as probably well placed to review this code

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 3, 2019

👋 @ejolly & @ghammad - would one or both of you be willing to review this JOSS submission? I'm looking for a total of 2 reviewers

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 3, 2019

👋 @taqtiqa-mark & @lindemann09 - would one or both of you be willing to review this JOSS submission? I'm looking for a total of 2 reviewers

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 3, 2019

👋 @jtmiclat & @Chilipp - would one or both of you be willing to review this JOSS submission? I'm looking for a total of 2 reviewers

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 3, 2019

👋 @sarats & @mathause - would one or both of you be willing to review this JOSS submission? I'm looking for a total of 2 reviewers

@Chilipp

This comment has been minimized.

Collaborator

Chilipp commented Jan 3, 2019

looks interesting @danielskatz. I would be willing to review it but I won't be available before January 16th.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 3, 2019

Thanks @Chilipp - this might be ok - let me see who else responds

@sarats

This comment has been minimized.

Collaborator

sarats commented Jan 3, 2019

@danielskatz If it's fine, I can get to it in a couple of weeks as well because of ECP and AMS conferences.

@taqtiqa-mark

This comment has been minimized.

Collaborator

taqtiqa-mark commented Jan 4, 2019

@danielskatz, sure I'm able to review this.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 4, 2019

Thanks @taqtiqa-mark. I would like to find two reviewers, and as you can see, a couple of other people are willing to review but not for a couple of weeks. If I can find one more person willing to review soon, we'll start; otherwise, we'll start in a day or two with the expectation that the second review will be a bit later than yours. So hold on for a day or two...

@mathause

This comment has been minimized.

mathause commented Jan 4, 2019

I could also only start to review mid/ end of January. So I suppose others are able to do it earlier than me.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 6, 2019

I'm going to wait one more day to see if anyone I've mentioned can start a review immediately, and if not, we'll start anyhow with the expectation that one reviewer won't start until mid January.

@ejolly

This comment has been minimized.

ejolly commented Jan 6, 2019

Sorry for the delayed response @danielskatz I've been traveling with limited access to email. Unfortunately, I too won't be able to start a review until the end of this month. Happy to do it then if that timeline works/makes sense.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 7, 2019

Ok, let's go ahead with @taqtiqa-mark and @Chilipp, recognizing that @Chilipp won't be able to start for another week.

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 7, 2019

@whedon assign @taqtiqa-mark as reviewer

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 7, 2019

@whedon add @Chilipp as reviewer

@whedon whedon assigned Chilipp and danielskatz and unassigned danielskatz Jan 7, 2019

@whedon

This comment has been minimized.

Collaborator

whedon commented Jan 7, 2019

OK, @Chilipp is now a reviewer

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 7, 2019

@whedon add @taqtiqa-mark as reviewer

@whedon whedon assigned Chilipp and danielskatz and unassigned danielskatz and Chilipp Jan 7, 2019

@whedon

This comment has been minimized.

Collaborator

whedon commented Jan 7, 2019

OK, @taqtiqa-mark is now a reviewer

@danielskatz

This comment has been minimized.

Collaborator

danielskatz commented Jan 7, 2019

@whedon start review

@whedon

This comment has been minimized.

Collaborator

whedon commented Jan 7, 2019

OK, I've started the review over in #1157. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment