New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update polish-legal.csl #3630

Merged
merged 3 commits into from Aug 4, 2018

Conversation

Projects
None yet
3 participants
@Jack1982
Contributor

Jack1982 commented Jul 30, 2018

Replaces "section" with "thesis" (PL: "teza") as is customary for citing legal commentaries.

Update polish-legal.csl
Replaces "section" with "thesis" (PL: "teza") as is customary for citing legal commentaries.
@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jul 30, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

csl-bot commented Jul 30, 2018

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Jul 30, 2018

😃 Your submission passed all our automated tests.

csl-bot commented Jul 30, 2018

😃 Your submission passed all our automated tests.

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Aug 4, 2018

😃 Your submission passed all our automated tests.

csl-bot commented Aug 4, 2018

😃 Your submission passed all our automated tests.

Show outdated Hide outdated polish-legal.csl
</if>
<else>
<group delimiter=" ">
<label variable="locator" form="short" suffix="."/>

This comment has been minimized.

@adam3smith

adam3smith Aug 4, 2018

Member

the suffix="." isn't really needed here, is it? The periods are already in the abbreviations. If that's right, we could just define teza as the short form of section above and the wouldn't have to have a separate if-else here but

       <group delimiter=" ">
          <label variable="locator" form="short"/>
          <text variable="locator"/>
        </group>

would just work for everything.

@adam3smith

adam3smith Aug 4, 2018

Member

the suffix="." isn't really needed here, is it? The periods are already in the abbreviations. If that's right, we could just define teza as the short form of section above and the wouldn't have to have a separate if-else here but

       <group delimiter=" ">
          <label variable="locator" form="short"/>
          <text variable="locator"/>
        </group>

would just work for everything.

This comment has been minimized.

@Jack1982

Jack1982 Aug 4, 2018

Contributor

I checked your proposal, works fine. Thank you!

@Jack1982

Jack1982 Aug 4, 2018

Contributor

I checked your proposal, works fine. Thank you!

@adam3smith adam3smith added the waiting label Aug 4, 2018

@csl-bot

This comment has been minimized.

Show comment
Hide comment
@csl-bot

csl-bot Aug 4, 2018

😃 Your submission passed all our automated tests.

csl-bot commented Aug 4, 2018

😃 Your submission passed all our automated tests.

@adam3smith adam3smith merged commit 155dfc4 into citation-style-language:master Aug 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adam3smith adam3smith removed the waiting label Aug 4, 2018

@adam3smith

This comment has been minimized.

Show comment
Hide comment
@adam3smith

adam3smith Aug 4, 2018

Member

thanks

Member

adam3smith commented Aug 4, 2018

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment