Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, and click on the pencil icon (see below) in the top-right corner of your style to start editing.

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

😃 Your submission passed all our automated tests.

Happy to discuss some of the decisions that had to be made. Specific areas that were challenging were accommodating:

1. Archival and non-archival manuscripts
2. Personal communications that are published/available versus not
3. Reports and songs that have container-titles versus don't

I added a few additional hard-coded strings (marked as in need of localization). Most of them should come up fairly rarely I suspect, but we can consider some alternative options if we want to break localization less until more terms can be added to CSL.

Question:

Is there any way to get a names element to render multiple creator types together, with the order presented in the item data, rather than separated by creator type? For example, if a book has two authors and an illustrator, then this:
<names variable="author illustrator" delimiter=", ">

Produces:
Author, F., & Author, S., Illustrator, F. (Ill.)

Rather than:
Author, F., Author, S., & Illustrator, F. (Ill.)

I had thought this code would produce the latter output (essentially all of the types inside a single variable command as equivalent. But re-reading the specification, it is clear that it doesn’t. This seems like a major limitation.

At minimum, it seems like there should be a way to specify that and should apply to the full list of creators, rather than to each sub-list. Even in the current APA style, it’s noy possible to correctly format a chapter in a book with both an editor and translator (who are separate people).

No -- every name call (i.e. every creator type) is being handled separately. I have to say that I find the second example really confusing, too, with no way of telling who the (Ill) refers to.

Here’s a more common example:

If I have a chapter in a book with an editor and a translator (different people), then the existing APA style renders as:
In A. S. Smith (Ed.), T. Jones (Trans.), Book

Rather than with the ampersand:
In A. S. Smith (Ed.) & T. Jones (Trans.), Book

This CSL behavior seems very counter intuitive to me. Particularly frustrating is that and can only be applied to name and not to names, so it is impossible to create continuous lists with multiple creator types. For example, it’s impossible to correctly format editor and translator combinations or to even approach a correct rendering for media creators:
Allen, A. (Director), Berry, B. (Director), & Collins, C. (Producer)

(But thanks for the clarification!)

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

@adam3smith Okay, I've run through a bunch of tests, and everything is looking good on my end. Once you've had a chance to review, I will port the changes over to the other APA versions.

😃 Your submission passed all our automated tests.

Oh, and of course thanks for doing this in the first place. (And so far I've only reviewed the APA changes.

😃 Your submission passed all our automated tests.

re: container titles -- yes, agreed. Since APA relies on bluebook for the legal cites, entering the abbreviations should almost universally work across styles. Beyond that, Zotero would need better abbreviation support to handle this properly.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

😃 Your submission passed all our automated tests.

Update: I've added all of the examples from the APA manual and guide to electronic references to my test library. I've fixed all of the bugs I ran into as I was cleaning those up. I will run through a final check of the 250 items to be sure they all still render correctly.

😃 Your submission passed all our automated tests.

Okay, all 251 items in the test library render correctly, or as correctly as they reasonably can. https://www.zotero.org/groups/2205533/test_items_library

In the library, items that produce output that deviates from the APA manual are tagged with incorrect output. Of those, CSL change indicates changes to CSL that are needed to meet the formatting requirements. weird APA notes places where APA is inconsistent examples or rules that are too difficult to be able to implement effectively.

It should be ready for your review now @adam3smith

😃 Your submission passed all our automated tests.

@adam3smith Would it be helpful to schedule a call to talk through this style?

@agruber reached out and is also interested in helping out here.

This is next up on my list to review. I figured what I'd do is go through this, including with the test library, and flag anything that I think is unreasonable or too fragile (as well, of course, as anything that I think is actually wrong). If there's a lot, jumping on a phone call will probably be most efficient, if there's just a couple of things we can hash them out here for transparency.
Thanks for doing this!