Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] [ruby] Update all of rails: 5.2.2 → 5.2.2.1 (minor) #272

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
1 participant
@depfu
Copy link
Contributor

depfu bot commented Mar 13, 2019


🚨 Your version of actionview has known security vulnerabilities 🚨

Advisory: CVE-2019-5419
Disclosed: March 13, 2019
URL: https://groups.google.com/forum/#!topic/rubyonrails-security/GN7w9fFAQeI

Denial of Service Vulnerability in Action View

There is a potential denial of service vulnerability in actionview.
This vulnerability has been assigned the CVE identifier CVE-2019-5419.

Impact

Specially crafted accept headers can cause the Action View template location
code to consume 100% CPU, causing the server unable to process requests. This
impacts all Rails applications that render views.

All users running an affected release should either upgrade or use one of the
workarounds immediately.

Workarounds

This vulnerability can be mitigated by wrapping render calls with
respond_to blocks. For example, the following example is vulnerable:

class UserController < ApplicationController
  def index
    render "index"
  end
end

But the following code is not vulnerable:

class UserController < ApplicationController
  def index
    respond_to |format|
      format.html { render "index" }
    end
  end
end

Implicit rendering is impacted, so this code is vulnerable:

class UserController < ApplicationController
  def index
  end
end

But can be changed this this:

class UserController < ApplicationController
  def index
    respond_to |format|
      format.html { render "index" }
    end
  end
end

Alternatively to specifying the format, the following monkey patch can be
applied in an initializer:

$ cat config/initializers/formats_filter.rb
# frozen_string_literal: true

ActionDispatch::Request.prepend(Module.new do
def formats
super().select do |format|
format.symbol || format.ref == "/"
end
end
end)

Credits

Thanks to John Hawthorn john@hawthorn.email of GitHub


🚨 We recommend to merge and deploy this update as soon as possible! 🚨

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rails (5.2.2 → 5.2.2.1) · Repo

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ actioncable (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ actionmailer (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ actionpack (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ actionview (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ activejob (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ activemodel (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ activerecord (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ activestorage (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

↗️ activesupport (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:

↗️ concurrent-ruby (indirect, 1.1.3 → 1.1.5) · Repo · Changelog

Release Notes

1.1.5 (from changelog)

concurrent-ruby:

  • fix potential leak of context on JRuby and Java 7

concurrent-ruby-edge:

  • Add finalized Concurrent::Cancellation
  • Add finalized Concurrent::Throttle
  • Add finalized Concurrent::Promises::Channel
  • Add new Concurrent::ErlangActor

1.1.4 (from changelog)

  • (#780) Remove java_alias of 'submit' method of Runnable to let executor service work on java 11
  • (#776) Fix NameError on defining a struct with a name which is already taken in an ancestor

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ erubi (indirect, 1.7.1 → 1.8.0) · Repo · Changelog

Release Notes

1.8.0 (from changelog)

* Support :yield_returns_buffer option in capture_end for always returning the (potentially modified) buffer in <%|= tags (evanleck) (#15)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ globalid (indirect, 0.4.1 → 0.4.2) · Repo · Changelog

Release Notes

0.4.2

  • Allow configuration in initialisers 3c8f909

  • Clear to_global_id memoization on dup #109

  • Adds hash equality #108

Commits: v0.4.1...v0.4.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 20 commits:

↗️ i18n (indirect, 1.2.0 → 1.6.0) · Repo · Changelog

↗️ mimemagic (indirect, 0.3.2 → 0.3.3) · Repo · Changelog

Release Notes

0.3.3 (from changelog)

Upgrade to shared-mime-info-1.10

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 14 commits:

↗️ mini_portile2 (indirect, 2.3.0 → 2.4.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ nokogiri (indirect, 1.8.5 → 1.10.1) · Repo · Changelog

Release Notes

1.10.1

1.10.1 / 2019-01-13

Features

  • [MRI] During installation, handle Xcode 10's new library pathOS. [#1801, #1851] (Thanks, @mlj and @deepj!)
  • Avoid unnecessary creation of Procs in many methods. [#1776] (Thanks, @chopraanmol1!)

Bug fixes

  • CSS selector :has() now correctly matches against any descendant. Previously this selector matched against only direct children). [#350] (Thanks, @Phrogz!)
  • NodeSet#attr now returns nil if it's empty. Previously this raised a NoMethodError.
  • [MRI] XPath errors are no longer suppressed during XSLT::Stylesheet#transform. Previously these errors were suppressed which led to silent failures and a subsequent segfault. [#1802]

1.10.0

1.10.0 / 2019-01-04

Features

  • [MRI] Cross-built Windows gems now support Ruby 2.6 [#1842, #1850]

Backwards incompatibilities

This release ends support for:

Dependencies

  • [MRI] libxml2 is updated from 2.9.8 to 2.9.9
  • [MRI] libxslt is updated from 1.1.32 to 1.1.33

1.9.1

1.9.1 / 2018-12-17

Bug fixes

  • Fix a bug introduced in v1.9.0 where XML::DocumentFragment#dup no longer returned an instance of the callee's class, instead always returning an XML::DocumentFragment. This notably broke any subclass of XML::DocumentFragment including HTML::DocumentFragment as well as the Loofah gem's Loofah::HTML::DocumentFragment. [#1846]

1.9.0

1.9.0 / 2018-12-17

Security Notes

  • [JRuby] Upgrade Xerces dependency from 2.11.0 to 2.12.0 to address upstream vulnerability CVE-2012-0881 [#1831] (Thanks @grajagandev for reporting.)

Notable non-functional changes

  • Decrease installation size by removing many unneeded files (e.g., /test) from the packaged gems. [#1719] (Thanks, @stevecrozz!)

Features

  • XML::Attr#value= allows HTML node attribute values to be set to either a blank string or an empty boolean attribute. [#1800]
  • Introduce XML::Node#wrap which does what XML::NodeSet#wrap has always done, but for a single node. [#1531] (Thanks, @ethirajsrinivasan!)
  • [MRI] Improve installation experience on macOS High Sierra (Darwin). [#1812, #1813] (Thanks, @gpakosz and @nurse!)
  • [MRI] Node#dup supports copying a node directly to a new document. See the method documentation for details.
  • [MRI] DocumentFragment#dup is now more memory-efficient, avoiding making unnecessary copies. [#1063]
  • [JRuby] NodeSet has been rewritten to improve performance! [#1795]

Bug fixes

  • NodeSet#each now returns self instead of zero. [#1822] (Thanks, @olehif!)
  • [MRI] Address a memory leak when using XML::Builder to create nodes with namespaces. [#1810]
  • [MRI] Address a memory leak when unparenting a DTD. [#1784] (Thanks, @stevecheckoway!)
  • [MRI] Use RbConfig::CONFIG instead of ::MAKEFILE_CONFIG to fix installations that use Makefile macros. [#1820] (Thanks, @nobu!)
  • [JRuby] Decrease large memory usage when making nested XPath queries. [#1749]
  • [JRuby] Fix failing tests on JRuby 9.2.x
  • [JRuby] Fix default namespaces in nodes reparented into a different document [#1774]
  • [JRuby] Fix support for Java 9. [#1759] (Thanks, @Taywee!)

Dependencies

  • [MRI] Upgrade mini_portile2 dependency from ~> 2.3.0 to ~> 2.4.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ railties (indirect, 5.2.2 → 5.2.2.1) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 3 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Mar 13, 2019

@ruebot

This comment has been minimized.

Copy link
Member

ruebot commented Mar 13, 2019

@​depfu rebase

@ruebot

ruebot approved these changes Mar 13, 2019

@ruebot ruebot merged commit 3fa1336 into master Mar 13, 2019

3 checks passed

codecov/patch Coverage not affected when comparing 3035011...4d4990f
Details
codecov/project 96.22% remains the same compared to 3035011
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@depfu depfu bot deleted the depfu/update/group/rails-5.2.2.1 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.