Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[J-Stage.js]: Fix cases when no pdf is available #1125

Merged
merged 2 commits into from Aug 27, 2016

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Aug 27, 2016

Also fixing the extraction of the abstract and updating the
structure of the translator in general. Add a new test case.

[J-Stage.js]: Fix cases when no pdf is available
Also fixing the extraction of the abstract and updating the
structure of the translator in general. Add a new test case.
@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Aug 27, 2016

( I noticed some potential problems for this translator by looking at the website https://repo.zotero.org/errors )

J-Stage.js Outdated
tags[i] = ZU.trimInternal(tags[i]);
}
tags = tags.replace(/Keywords:/, "").split(/\s*,\s*/);
for (var i in tags) {

This comment has been minimized.

@adam3smith

adam3smith Aug 27, 2016

Collaborator

might as well do this properly with (i = 0; i<tags.length; i++)

J-Stage.js Outdated
@@ -94,29 +101,35 @@ function scrape(doc, url) {
translator.setHandler("itemDone", function (obj, item) {
if (abs) item.abstractNote = abs;
if (tags) item.tags = tags;
for (i in item.creators) {
for (var i in item.creators) {

This comment has been minimized.

@adam3smith

adam3smith Aug 27, 2016

Collaborator

ditto here.

J-Stage.js Outdated
item.attachments = [{
url: item.url,
item.attachments.push({
url: url,
title: "Jstage - Snapshot",

This comment has been minimized.

@adam3smith

adam3smith Aug 27, 2016

Collaborator

Let's use J-Stage here and l. 129 for the PDF, in line with the library catalog and translator label.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Aug 27, 2016

a couple of comments, should be quick. thanks!

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Aug 27, 2016

Please have a look at the new version.

@adam3smith adam3smith merged commit 055fa20 into zotero:master Aug 27, 2016

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Aug 27, 2016

great, thanks

@zuphilip zuphilip deleted the zuphilip:jstage branch Aug 27, 2016

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

[J-Stage.js]: Fix cases when no pdf is available (zotero#1125)
Also fixing the extraction of the abstract and updating the
structure of the translator in general. Add a new test case.

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

[J-Stage.js]: Fix cases when no pdf is available (zotero#1125)
Also fixing the extraction of the abstract and updating the
structure of the translator in general. Add a new test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.