Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes VW #1337

Merged
merged 14 commits into from Jun 25, 2017

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Jun 18, 2017

No description provided.

for (var i=0; i<authorsList.length; i++) {
item.creators.push(ZU.cleanAuthor(authorsList[i], "author"));
}
}

This comment has been minimized.

@adam3smith

adam3smith Jun 25, 2017

Collaborator

Any objection to hardcoding the ISSN (0043-0633) for magazine Articles?

"language": "English",
"libraryCatalog": "WorldCat Discovery Service",
"numPages": "xx, 404",
"place": "Peabody, Mass.",
"publisher": "Hendrickson Publishers Marketing",
"series": "Lexham Bible reference series; Lexham Bible reference series.",
"shortTitle": "Discourse grammar of the Greek New Testament",
"url": "Table of contents http://bvbr.bib-bvb.de:8991/F?func=service&doc_library=BVB01&local_base=BVB01&doc_number=024386228&line_number=0001&func_code=DB_RECORDS&service_type=MEDIA",

This comment has been minimized.

@adam3smith

adam3smith Jun 25, 2017

Collaborator

Not liking this. Could we do something like

  1. Check if URL is actually a URL
    2 a) if it is, then import it into URL field
    2 b) if it is not, check if it's a ToC and then turn it into attached link with appropriate title?
@adam3smith
Copy link
Collaborator

adam3smith left a comment

Looks great -- I have two individual questions/comments. See what you think on those. Otherwise gtg.

Fixes VW: Changes suggest by review
* Adds the ISSN for magazinArticles in Washington Monthly.js
* Deals with urls and labels in url field in WorldCat Discovery Service.js
@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Jun 25, 2017

Please have a look at the new version.

@adam3smith adam3smith merged commit 64830cc into zotero:master Jun 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Jun 25, 2017

Cool, thanks!

@zuphilip zuphilip deleted the zuphilip:fixes-VW branch Jun 26, 2017

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Fixes VW (zotero#1337)
* Update WorldCat Discovery Service.js
* Updatetests in WIPO.js
* Rewrite Winnipeg Free Press.js and add some test cases
* Update tests in Wiley Online Library.js
* Update tests in Wikipedia.js
* Update tests in Wikimedia Commons.js
* Update tests in WikiLeaks PlusD.js
* Update Welt Online.js
* Rewrite Washington Monthly.js and activate tests again
* Rewrite washingtonpost.com.js
* Update test in VoxEU.js
* Delete Vanderbilt eJournals.js covered now by OJS.js
* Add some alternative extraction methods in Open Journal Systems.js
 Delete first test case in OJS which was timed out frequently
 Update some test cases in OJS
* Fix detection of multiples in Vimeo.js

zuphilip added a commit to zuphilip/translators that referenced this pull request Mar 28, 2018

Fixes VW (zotero#1337)
* Update WorldCat Discovery Service.js
* Updatetests in WIPO.js
* Rewrite Winnipeg Free Press.js and add some test cases
* Update tests in Wiley Online Library.js
* Update tests in Wikipedia.js
* Update tests in Wikimedia Commons.js
* Update tests in WikiLeaks PlusD.js
* Update Welt Online.js
* Rewrite Washington Monthly.js and activate tests again
* Rewrite washingtonpost.com.js
* Update test in VoxEU.js
* Delete Vanderbilt eJournals.js covered now by OJS.js
* Add some alternative extraction methods in Open Journal Systems.js
 Delete first test case in OJS which was timed out frequently
 Update some test cases in OJS
* Fix detection of multiples in Vimeo.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.