Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text search for GBV and LoC #1619

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@mrtcode
Copy link
Contributor

mrtcode commented Apr 12, 2018

No description provided.

@mrtcode mrtcode referenced this pull request Apr 12, 2018

Merged

Add text search #57

else if (item.query) {
url = "http://lx2.loc.gov:210/LCDB?operation=searchRetrieve&version=1.1&query=" + encodeURIComponent(item.query) + "&maximumRecords=50";
}
else return;

This comment has been minimized.

@dstillman

dstillman Apr 12, 2018

Member

We'd want braces here for style reasons, but the else can just be removed from both translators. While at the moment we're not testing for query in detectSearch, the assumption in translators is always that the page/input should clear detect* in order for do* to be called (and it'd be fine for doGet to throw an error on an empty url if that didn't happen for some reason).

@zuphilip

This comment has been minimized.

Copy link
Collaborator

zuphilip commented Apr 13, 2018

You need to update the timestamp of the two translators.

@dstillman

This comment has been minimized.

Copy link
Member

dstillman commented Apr 13, 2018

This has a conflict with the GBV translator now. Can you rebase?

@mrtcode mrtcode force-pushed the mrtcode:gbv-loc-text-search branch from f2b5e3f to 44a0e9a Apr 16, 2018

@dstillman dstillman merged commit 79c2ecc into zotero:master Apr 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.