Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WHO translator and fixing nits in Copernicus translator #1731

Merged
merged 7 commits into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Sep 2, 2018

I cherry-picked from the commits by @mtrojan-ub, rebased them and rewrote the WHO translator.

This superseeds #1593.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Sep 2, 2018

This fixes issues #1544 and #791.

WHO.js Outdated
// copy meta tags in body to head
var head = doc.getElementsByTagName('head');
var metasInBody = ZU.xpath(doc, '//body/meta');
for (let i=0; i<metasInBody.length; i++) {

This comment has been minimized.

@adam3smith

adam3smith Sep 2, 2018

Collaborator

FWIW, I think Zotero house style now prefers for (let item of array) to cycle through arrays unless you need the index. I'll change that here, but I don't think it's worth it going through translators since there's no effective difference.

@adam3smith

This comment has been minimized.

Copy link
Collaborator

adam3smith commented Sep 2, 2018

@zuphilip see what you think of my edit. Otherwise good to merge.

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Sep 2, 2018

Thank you! These are good improvements. I tried to clarify the comment and am otherwise happy with this.

@zuphilip zuphilip merged commit 803f04c into zotero:master Sep 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:mtrojan-who branch Sep 2, 2018

@zuphilip

This comment has been minimized.

Copy link
Collaborator Author

zuphilip commented Sep 2, 2018

Thank you @mtrojan-ub for starting with this work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.