Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPI.js #1779

Merged
merged 2 commits into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@zuphilip
Copy link
Collaborator

zuphilip commented Nov 3, 2018

This fixes #1772.

zuphilip added some commits Nov 3, 2018

Update PyPI.js
This fixes #1772.
@adam3smith
Copy link
Collaborator

adam3smith left a comment

Looks good, but you've lost the version number for reasons I can't quite make out (or maybe just didn't update the tests after fixing via \s*?). Could you check?

var found = item.title.match(/\sv?([\d.]+)$/);
// info from h1 and meta tag
item.title = ZU.xpathText(doc, '//h1[contains(@class, "package-header__name")]');
var found = item.title.match(/\sv?([\d.]+)\s*$/);

This comment has been minimized.

@adam3smith

adam3smith Nov 4, 2018

Collaborator

This doesn't seem to work, at least going by the tests. I can't quite figure out why not, but please take a look.

This comment has been minimized.

@zuphilip

zuphilip Nov 4, 2018

Author Collaborator

It should work in Zotero, but there might be a problem with Scaffold. You can see the changes in my last commit, where I changed from versionNumber to version (nothing more changed), cf. e73d7d8

This comment has been minimized.

@adam3smith

adam3smith Nov 4, 2018

Collaborator

Thanks -- tested in Zotero. I had a quick look in the scaffold code, but I've never worked with it and couldn't see anything obvious.

@adam3smith adam3smith merged commit 313362a into zotero:master Nov 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zuphilip zuphilip deleted the zuphilip:pypi2018 branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.