Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAddresses Issue 70 - Vancouver Projects #72
+69
−82
Conversation
SamFritz
added some commits
Nov 9, 2018
SamFritz
added
documentation
clean-up
labels
Nov 13, 2018
SamFritz
self-assigned this
Nov 13, 2018
SamFritz
requested review from
ruebot and
ianmilligan1
Nov 13, 2018
content/vancouver/index.md
Outdated
| <tr> | ||
| <td><b>Team IDG</b> | ||
| <ul> | ||
| <li>Ben O'Brien, <em>(National Library of New Zealand)</em></li> |
This comment has been minimized.
This comment has been minimized.
ianmilligan1
Nov 13, 2018
Member
I think in the list format we can remove the trailing , between name and institution
content/vancouver/index.md
Outdated
| <td><b>Team IDG</b> | ||
| <ul> | ||
| <li>Ben O'Brien, <em>(National Library of New Zealand)</em></li> | ||
| <li>Carl Cooper, <em>(Bodleian Libraries - Oxford University)</em></li> |
This comment has been minimized.
This comment has been minimized.
content/vancouver/index.md
Outdated
| <tr> | ||
| <td><b>Team BC 2017 Politics</b> | ||
| <ul> | ||
| <li>Matt Huculak, <em>(University of Victoria)</em></li> |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good to me! If it looks good to you @ruebot I can merge + deploy. |
ianmilligan1
merged commit 31a3b3c
into
master
Nov 13, 2018
ianmilligan1
deleted the
issue-70
branch
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
SamFritz commentedNov 13, 2018
Resolves issue 70
This pull request updates the Vancouver datathon page to include team projects and removes trip planning information (no longer necessary).
Commit also includes minor clean up of spacing on GWU event page. Major updates for GWU will be included in a separate ticket and PR
Just needs a quick look over and we'll be good to publish.