Skip to content

/auk-notebooks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install deps with requirements.txt; resolve #32. #33

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Reviewers

@ianmilligan1 ianmilligan1

@SamFritz SamFritz

@greebie greebie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ruebot @ianmilligan1 @SamFritz
@ruebot
Copy link
Member

ruebot commented Mar 6, 2019

  • Add requirements.txt
  • Update Docker to install depencies with requirements.txt
  • Remove nltk_data
  • Install nltk_data on Docker build
  • Update README with new instructions
@ruebot
Install deps with requirements.txt; resolve #32. 
- Add requirements.txt
- Update Docker to install depencies with requirements.txt
- Remove nltk_data
- Install nltk_data on Docker build
- Update README with new instructions
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
Loading status checks…
7ed5ae9

@ruebot ruebot requested review from greebie , ianmilligan1 and SamFritz Mar 6, 2019

@SamFritz

SamFritz approved these changes Mar 7, 2019
View changes

Copy link
Member

SamFritz left a comment

my review is directly related to readme. Thanks @ruebot for the additions under local (Anaconda), this works really well! I was able to get the notebook running without any nltk issues or errors.
@ianmilligan1

ianmilligan1 approved these changes Mar 7, 2019
View changes

Copy link
Member

ianmilligan1 left a comment

Works great - tested with both the local anaconda install and the docker build.

@ianmilligan1 ianmilligan1 merged commit 9afb3eb into master Mar 7, 2019
1 check passed

1 check passed

ci/dockercloud Your tests passed in Docker Cloud
Details

@ianmilligan1 ianmilligan1 deleted the issue-32 branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.