Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate Docs, About, and Learning Guides to Include Full-Text by Domain Derivative, Resolves #202 #205
+10
−8
Conversation
ianmilligan1
added some commits
Nov 2, 2018
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 5, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 35 35
Lines 529 529
=======================================
Hits 489 489
Misses 40 40Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
|
Updated with your new image, @SamFritz – thanks! Can you review this PR? |
ianmilligan1
requested a review
from
SamFritz
Nov 9, 2018
This comment has been minimized.
This comment has been minimized.
|
Looks good on my end (code and localhost) |
ruebot
merged commit e3808ce
into
master
Nov 9, 2018
ruebot
deleted the
issue-202
branch
Nov 9, 2018
This comment has been minimized.
This comment has been minimized.
|
Deployed to production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedNov 5, 2018
GitHub issue(s):
If you are responding to an issue, please mention their numbers below.
What does this Pull Request do?
This adds discussion of the new "full-text by domain" derivative to the
How should this be tested?
Should build, but more importantly, a second set of eyes should read the text.
Additional Notes:
Text has been updated, but needs new image as per comment in #202. I'll make a comment below.
Interested parties
@SamFritz @ruebot