Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdds note about Safari, resolves #206 #209
Conversation
ianmilligan1
requested a review
from
SamFritz
Nov 10, 2018
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Nov 10, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 35 35
Lines 529 529
=======================================
Hits 489 489
Misses 40 40Continue to review full report at Codecov.
|
ruebot
requested changes
Nov 12, 2018
We use <code>to wrap the file extensions in gephi.html.rb, so we should probably use it in documentation.html.erb.
ruebot
approved these changes
Nov 12, 2018
Looks good to me.
@SamFritz when you're good to go, let me know and I'll get this merged and put into production.
ruebot
merged commit c30c152
into
master
Nov 12, 2018
ruebot
deleted the
issue-206
branch
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
|
Deployed to production |
This comment has been minimized.
This comment has been minimized.
|
Thanks @ruebot! Nice work @ianmilligan1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedNov 10, 2018
I've seen this issue now at both a workshop and our recent hackathon. As noted in #206, Safari adds
.xmlto the end of thegexfandgraphmldownloads. I've played around with various settings in the browser preferences, and I think the most straightforward instruction is for users to just remove the.xmlextension.If they don't, the file won't load in Gephi.