Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upExplaining graph visualization, partially resolves #275 #277
+7
−3
Conversation
ianmilligan1
added some commits
Mar 27, 2019
ianmilligan1
requested a review
from
ruebot
Mar 27, 2019
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Mar 27, 2019
•
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 35 35
Lines 557 557
=======================================
Hits 536 536
Misses 21 21Continue to review full report at Codecov.
|
ruebot
approved these changes
Mar 27, 2019
ruebot
merged commit 9a80b86
into
master
Mar 27, 2019
ruebot
deleted the
issue-275
branch
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ianmilligan1 commentedMar 27, 2019
GitHub issue(s):
If you are responding to an issue, please mention their numbers below.
What does this Pull Request do?
This pull request partially resolves #275 by explaining the graph visualization, both the in-browser sigma one as well as the Gephi download.
How should this be tested?
It should build locally, pass style checks (I've tried my best), and the tooltip should pop up.