Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSetup ESlint for project; resolves #89. #97
Conversation
This comment has been minimized.
This comment has been minimized.
|
Oh yeah, TravisCI runs the ESlinting now too, so that should be good too. |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 8, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 26 26
Lines 239 239
=======================================
Hits 208 208
Misses 31 31Continue to review full report at Codecov.
|
ianmilligan1
reviewed
Apr 9, 2018
|
Tested – both successfully with everything, and also successfully caught that files were missing when they were removed. |
ruebot
changed the title
Setup ESlint to project; resolves #89.
Setup ESlint for project; resolves #89.
Apr 9, 2018
ruebot
requested a review
from
greebie
Apr 9, 2018
greebie
reviewed
Apr 9, 2018
| { | ||
| "extends": "airbnb-base/legacy", | ||
| "globals": { | ||
| "jQuery": true, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
lgtm. Only comment is the optional add of |
ruebot
dismissed
ianmilligan1’s
stale review
via
761388a
Apr 9, 2018
ianmilligan1
approved these changes
Apr 9, 2018
greebie
approved these changes
Apr 9, 2018
ianmilligan1
merged commit d15b88b
into
master
Apr 9, 2018
4 checks passed
ruebot
deleted the
eslint
branch
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ruebot commentedApr 8, 2018
I've tested locally by moving the
gexffile, and also removing all the nodes and edges to simulate an empty graph so recreate the two conditionals. Everything looks fine, but just want to make sure things are good not on my laptop.@greebie and @ianmilligan1 would you mind doing a smoke test on your end?