/graphpass

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up and organize project; partially resolves #40. #48

Closed
wants to merge 1 commit into
base: master
from
+1,106 −1,283

Conversation

Reviewers

@ianmilligan1 ianmilligan1

@greebie greebie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ruebot @ianmilligan1
@ruebot
Member

ruebot commented Sep 3, 2018

GitHub issue(s): #40

What does this Pull Request do?

  • Moves Docs -> doc
  • Moves tests -> src/tests
  • Moves headers -> src/headers
  • Moves src/*.c -> src/main
  • Moves unity -> vendor/unity
  • Updates Doxygen config
  • Update Doxygen generated docs
  • Update README
  • Update all src files that need to be updated to reflect re-org
  • Update Makefile so project builds

How should this be tested?

It should build, test should pass, and it should still run as it currently does. I've built, and test it with auk locally, and everything appears to be working fine.

Additional Notes:

We need to create a ticket for automake and push a branch for that with the existing configure.scan. I'll take care of that later today, or later this week.
@ruebot
Clean-up and organize project; partially resolves #40. 
- Moves Docs -> doc
- Moves tests -> src/tests
- Moves headers -> src/headers
- Moves src/*.c -> src/main
- Moves unity -> vendor/unity
- Updates Doxygen config
- Update Doxygen generated docs
- Update README
- Update all src files that need to be updated to reflect re-org
- Update Makefile so project builds
Verified
This commit was signed with a verified signature.
@ruebot ruebot Nick Ruest
GPG key ID: 417FAF1A0E1080CD Learn about signing commits
c23f409

@ruebot ruebot requested review from greebie and ianmilligan1 Sep 3, 2018

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 3, 2018

Member

I believe #40 will be fully resolved by merging this, and creating the new automake ticket and pushing the branch for it.
Member

ruebot commented Sep 3, 2018

I believe #40 will be fully resolved by merging this, and creating the new automake ticket and pushing the branch for it.
@ianmilligan1

ianmilligan1 approved these changes Sep 3, 2018
View changes

Builds locally and tested some outputs in AUK - all good on my end. 👍

@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 3, 2018

Member

autoconf ticket #49, and branch is here.

Merging this should now fully resolve #40.
Member

ruebot commented Sep 3, 2018

autoconf ticket #49, and branch is here.

Merging this should now fully resolve #40.
@ruebot

This comment has been minimized.

Show comment
Hide comment
@ruebot

ruebot Sep 3, 2018

Member

I did some subtle changes to the Makefile, cleaned up whitespace, and squashed & rebased. I'm going to close this and push up a new PR since GitHub isn't picking it up again. 🤷‍♂️
Member

ruebot commented Sep 3, 2018

I did some subtle changes to the Makefile, cleaned up whitespace, and squashed & rebased. I'm going to close this and push up a new PR since GitHub isn't picking it up again. 🤷‍♂️

@ruebot ruebot closed this Sep 3, 2018

@ruebot ruebot deleted the ruebot:issue-40 branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment